Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-5049 / Enter existing mt5 password modal #17494

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Nov 13, 2024

Changes:

  • Fix title, description and CTA content for MT5 enter password modal in desktop and responsive
  • Fix button disabling logic for CTA
  • Fix validation for enter password modal to not check for warning message
  • Fix unit test with updated logic

Screenshots:

Bildschirmfoto 2024-11-14 um 2 27 39 PM Bildschirmfoto 2024-11-14 um 2 27 57 PM

Recording:

Bildschirmaufnahme.2024-11-14.um.2.18.46.PM.mov

Password change modal behaviour:

Bildschirmaufnahme.2024-11-14.um.3.05.23.PM.mov

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 14, 2024 7:02am

Copy link
Contributor

github-actions bot commented Nov 13, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17494](https://github.com/deriv-com/deriv-app/pull/17494)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-5049-enter-existing-aa8fa8.binary.sx?qa_server=red.derivws.com&app_id=23883
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-5049-enter-existing-aa8fa8.binary.sx
- **App ID**: `23883`

@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11832345235

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • 180 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.04%) to 53.155%

Files with Coverage Reduction New Missed Lines %
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier.tsx 1 77.78%
packages/wallets/src/components/DerivAppsSection/DerivAppsGetAccount.tsx 1 89.8%
packages/wallets/src/features/cfd/screens/CompareAccounts/CompareAccountsTitleIcon.tsx 1 95.06%
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx 2 94.59%
packages/wallets/src/components/DerivAppsSection/DerivAppsTradingAccount.tsx 2 80.65%
packages/wallets/src/components/OptionsAndMultipliersListing/OptionsAndMultipliersListing.tsx 2 83.67%
packages/wallets/src/features/cfd/components/CFDPlatformsListAccounts/CFDPlatformsListAccounts.tsx 3 56.52%
packages/wallets/src/features/cfd/constants.tsx 4 74.47%
packages/wallets/src/features/cfd/screens/CompareAccounts/compareAccountsConfig.ts 5 77.65%
packages/trader/src/AppV2/Components/TradeParameters/Stake/stake.tsx 7 87.08%
Totals Coverage Status
Change from base Build 11811544271: -0.04%
Covered Lines: 32704
Relevant Lines: 57378

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Nov 13, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-5049-enter-existing-aa8fa8.binary.sx/

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants