Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aswathy/CRO-778/feat: Added the console error tracking for the virtual signup flow #17497

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aswathy-deriv
Copy link
Contributor

@aswathy-deriv aswathy-deriv commented Nov 13, 2024

Changes:

Added the screen_name and action signup_flow_error for the event ce_virtual_signup_formand the error_message from trackjs if there is any error coming in the console for the country_selection and password_selection page

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 15, 2024 11:41am

@aswathy-deriv aswathy-deriv changed the title Aswathy/feat: added the console error tracking for the virtual signup flow Aswathy/CRO-778/feat: added the console error tracking for the virtual signup flow Nov 13, 2024
@aswathy-deriv aswathy-deriv changed the title Aswathy/CRO-778/feat: added the console error tracking for the virtual signup flow Aswathy/CRO-778/feat: Added the console error tracking for the virtual signup flow Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17497](https://github.com/deriv-com/deriv-app/pull/17497)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aswathy-deriv-track-console-error.binary.sx?qa_server=red.derivws.com&app_id=24064
    - **Original**: https://deriv-app-git-fork-aswathy-deriv-track-console-error.binary.sx
- **App ID**: `24064`

Copy link
Contributor

github-actions bot commented Nov 13, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aswathy-deriv-track-console-error.binary.sx/

@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11855328508

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 24 (0.0%) changed or added relevant lines in 2 files are covered.
  • 264 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-0.02%) to 53.172%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/Utils/Analytics/analytics.ts 0 9 0.0%
packages/core/src/App/Containers/AccountSignupModal/account-signup-modal.jsx 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
packages/appstore/src/constants/wallet-migration-video-translations.ts 1 71.43%
packages/bot-web-ui/src/pages/bot-builder/quick-strategy/inputs/qs-input-label.tsx 1 71.43%
packages/bot-web-ui/src/pages/bot-builder/quick-strategy/selects/symbol.tsx 1 97.22%
packages/core/src/App/Containers/AccountSignupModal/account-signup-modal.jsx 1 0.0%
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier.tsx 1 77.78%
packages/wallets/src/components/DerivAppsSection/DerivAppsGetAccount.tsx 1 89.8%
packages/wallets/src/features/cfd/screens/CompareAccounts/CompareAccountsTitleIcon.tsx 1 95.06%
packages/bot-web-ui/src/analytics/rudderstack-common-events.ts 2 87.5%
packages/bot-web-ui/src/pages/bot-builder/quick-strategy/config.ts 2 94.74%
packages/bot-web-ui/src/pages/bot-builder/quick-strategy/form-wrappers/upgraded-qs-v2/mobile-form-wrapper.tsx 2 2.56%
Totals Coverage Status
Change from base Build 11812079215: -0.02%
Covered Lines: 32740
Relevant Lines: 57462

💛 - Coveralls

const [is_disclaimer_accepted, setIsDisclaimerAccepted] = React.useState(false);
const [is_questionnaire, setIsQuestionnaire] = React.useState(false);
const [ab_questionnaire, setABQuestionnaire] = React.useState();
const [modded_state, setModdedState] = React.useState({});
const language = getLanguage();

const [is_signup_flow_error] = useGrowthbookGetFeatureValue({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the expected behaviour of this feature flag?
I dont understand it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is also vague.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's like enable_signup_error_tracking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its like should we enable the signup_flow_error feature flag or not

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants