DTRA-1886 / Kate / Trade type updates #17501

kate-deriv · 2024-11-13T10:30:23Z

Changes:

Expanded functionality of Carousel: added opportunity to pass custom icons (instead of default arrows) and callbacks for onNextButtonClick and onPreviousButtonClick.
Refactored Guide and GuideDescriptionModal: made triggering button optional, added opportunity to chose if the content should be shown in a modal or not. Did decomposition.
Refactored TradeTypes: added carousel inside, did decomposition.
Removed divider from trade types list.
Refactored tests.

Screenshots:

Screen.Recording.2024-11-13.at.5.54.46.PM.mov

vercel · 2024-11-13T10:30:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Nov 13, 2024 3:30pm

github-actions · 2024-11-13T10:54:28Z

A production App ID was automatically generated for this PR. (log)

PR: DTRA-1886 / Kate / Trade type updates #17501
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-kate-deriv-kate-dtra-1886addcarouselt-1c6c3f.binary.sx?qa_server=red.derivws.com&app_id=23938
- Original: https://deriv-app-git-fork-kate-deriv-kate-dtra-1886addcarouselt-1c6c3f.binary.sx
App ID: 23938

Click here to copy & paste above information.

- **PR**: [https://github.com/deriv-com/deriv-app/pull/17501](https://github.com/deriv-com/deriv-app/pull/17501)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1886addcarouselt-1c6c3f.binary.sx?qa_server=red.derivws.com&app_id=23938
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1886addcarouselt-1c6c3f.binary.sx
- **App ID**: `23938`

github-actions · 2024-11-13T10:55:30Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	31
🟧 Accessibility	70
🟢 Best practices	92
🟧 SEO	77
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-1886addcarouselt-1c6c3f.binary.sx/

coveralls · 2024-11-13T10:57:03Z

Pull Request Test Coverage Report for Build 11820720075

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

44 of 45 (97.78%) changed or added relevant lines in 9 files are covered.
166 unchanged lines in 13 files lost coverage.
Overall coverage decreased (-0.04%) to 53.165%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/trader/src/AppV2/Containers/Trade/trade-types.tsx	4	5	80.0%

Files with Coverage Reduction	New Missed Lines	%
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier.tsx	1	77.78%
packages/wallets/src/components/DerivAppsSection/DerivAppsGetAccount.tsx	1	89.8%
packages/wallets/src/features/cfd/screens/CompareAccounts/CompareAccountsTitleIcon.tsx	1	95.06%
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx	2	94.59%
packages/trader/src/AppV2/Utils/trade-params-utils.tsx	2	86.4%
packages/wallets/src/components/DerivAppsSection/DerivAppsTradingAccount.tsx	2	80.65%
packages/wallets/src/components/OptionsAndMultipliersListing/OptionsAndMultipliersListing.tsx	2	83.67%
packages/wallets/src/features/cfd/components/CFDPlatformsListAccounts/CFDPlatformsListAccounts.tsx	3	56.52%
packages/wallets/src/features/cfd/constants.tsx	4	74.47%
packages/wallets/src/features/cfd/screens/CompareAccounts/compareAccountsConfig.ts	5	77.65%

Totals
Change from base Build 11814538338:	-0.04%
Covered Lines:	32713
Relevant Lines:	57387

💛 - Coveralls

kate-deriv · 2024-11-13T12:45:16Z

packages/trader/src/AppV2/Components/DraggableList/draggable-list.tsx

@@ -57,9 +62,9 @@ const DraggableCategory: React.FC<{
    category: TDraggableListCategory;
    draggedItemId: string | null;
    onRightIconClick: (item: TDraggableListItem) => void;
-    onAction?: () => void;
-}> = ({ category, draggedItemId, onRightIconClick, onAction }) => (


onAction was not used in this file, hence removing

kate-deriv · 2024-11-13T14:44:26Z

packages/trader/src/AppV2/Components/Carousel/__tests__/carousel-header.spec.tsx

        render(<CarouselHeader {...mock_props} current_index={1} />);

        const arrow_icon = screen.getByText('LabelPairedArrowLeftMdRegularIcon');
        expect(arrow_icon).toBeInTheDocument();

        expect(mock_props.onPrevClick).not.toBeCalled();
-        userEvent.click(arrow_icon);
+        await userEvent.click(arrow_icon);


Here and below all async-await were added automatically

kate-deriv · 2024-11-13T14:52:52Z

packages/trader/src/AppV2/Containers/Trade/trade-types.tsx

+                            pages={action_sheet_content}
+                            title={<Localize i18n_default_text='Trade types' />}
+                            next_icon={LabelPairedPresentationScreenSmRegularIcon}
+                            onNextButtonClick={() => sendOpenGuideToAnalytics(contract_type, 'trade_type_page')}


Added function for analytics collection. Previously it was inside Guide button, but now we are not rendering this part in trade type selection modal.

cc: @vinu-deriv

github-actions · 2024-11-13T15:58:46Z

⏳ Generating Lighthouse report...

feat: add carousel for trade type selection modal

84d8660

kate-deriv temporarily deployed to Preview November 13, 2024 10:30 — with GitHub Actions Inactive

kate-deriv deployed to Preview November 13, 2024 10:31 — with GitHub Actions View deployment

refactor: add conditions for showing divider

86357c1

kate-deriv temporarily deployed to Preview November 13, 2024 12:16 — with GitHub Actions Inactive

kate-deriv deployed to Preview November 13, 2024 12:16 — with GitHub Actions View deployment

kate-deriv commented Nov 13, 2024

View reviewed changes

refactor: add tests and remove todos

6beea71

kate-deriv temporarily deployed to Preview November 13, 2024 14:41 — with GitHub Actions Inactive

kate-deriv deployed to Preview November 13, 2024 14:41 — with GitHub Actions View deployment

kate-deriv commented Nov 13, 2024

View reviewed changes

chore: extract common props

edfb092

kate-deriv temporarily deployed to Preview November 13, 2024 14:50 — with GitHub Actions Inactive

kate-deriv deployed to Preview November 13, 2024 14:50 — with GitHub Actions View deployment

kate-deriv commented Nov 13, 2024

View reviewed changes

kate-deriv marked this pull request as ready for review November 13, 2024 15:41

kate-deriv requested review from nijil-deriv, vinu-deriv and wojciech-deriv as code owners November 13, 2024 15:41

kate-deriv changed the title ~~DTRA-1886 / Kate / Trade type updates [WIP]~~ DTRA-1886 / Kate / Trade type updates Nov 13, 2024

vinu-deriv approved these changes Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DTRA-1886 / Kate / Trade type updates #17501

DTRA-1886 / Kate / Trade type updates #17501

kate-deriv commented Nov 13, 2024 •

edited

Loading

vercel bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

coveralls commented Nov 13, 2024 •

edited

Loading

kate-deriv Nov 13, 2024

kate-deriv Nov 13, 2024

kate-deriv Nov 13, 2024 •

edited

Loading

kate-deriv Nov 14, 2024

github-actions bot commented Nov 13, 2024 •

edited

Loading

DTRA-1886 / Kate / Trade type updates #17501

Are you sure you want to change the base?

DTRA-1886 / Kate / Trade type updates #17501

Conversation

kate-deriv commented Nov 13, 2024 • edited Loading

Changes:

Screenshots:

vercel bot commented Nov 13, 2024 • edited Loading

github-actions bot commented Nov 13, 2024 • edited Loading

github-actions bot commented Nov 13, 2024 • edited Loading

coveralls commented Nov 13, 2024 • edited Loading

Pull Request Test Coverage Report for Build 11820720075

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

kate-deriv Nov 13, 2024

Choose a reason for hiding this comment

kate-deriv Nov 13, 2024

Choose a reason for hiding this comment

kate-deriv Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

kate-deriv Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 13, 2024 • edited Loading

kate-deriv commented Nov 13, 2024 •

edited

Loading

vercel bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

coveralls commented Nov 13, 2024 •

edited

Loading

kate-deriv Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading