Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL5102 / PA - Incorrect limit value shown for Transfer to client in Crypto Cashier page #17506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

  • add reaction to invalidate transfer limits if the loginid was changed

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 13, 2024 7:11pm

Copy link
Contributor

github-actions bot commented Nov 13, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17506](https://github.com/deriv-com/deriv-app/pull/17506)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-5102-pa-incorrect-l-9c601f.binary.sx?qa_server=red.derivws.com&app_id=31524
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-5102-pa-incorrect-l-9c601f.binary.sx
- **App ID**: `31524`

Copy link
Contributor

github-actions bot commented Nov 13, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-5102-pa-incorrect-l-9c601f.binary.sx/

@heorhi-deriv heorhi-deriv force-pushed the WALL-5102-PA---Incorrect-limit-value-shown-for-Transfer-to-client-in-Crypto-Cashier-page branch from 456a325 to dc8895f Compare November 13, 2024 18:23
@heorhi-deriv heorhi-deriv reopened this Nov 13, 2024
@heorhi-deriv heorhi-deriv force-pushed the WALL-5102-PA---Incorrect-limit-value-shown-for-Transfer-to-client-in-Crypto-Cashier-page branch from 632725d to 5e8ef63 Compare November 13, 2024 18:25
@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11823460649

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 53.154%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/cashier/src/stores/payment-agent-transfer-store.ts 7 8 87.5%
Totals Coverage Status
Change from base Build 11820031634: 0.002%
Covered Lines: 32703
Relevant Lines: 57378

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants