-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shayan/FEQ-2696/Fix redundant Cloudflare trace API calls #91
Open
shayan-deriv
wants to merge
4
commits into
master
Choose a base branch
from
shayan/FEQ-2696/fix-network-failing-on-cloudflare-cgi-trace-request
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Shayan/FEQ-2696/Fix redundant Cloudflare trace API calls #91
shayan-deriv
wants to merge
4
commits into
master
from
shayan/FEQ-2696/fix-network-failing-on-cloudflare-cgi-trace-request
+50
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayan-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
wojciech-deriv and
niloofar-deriv
as code owners
November 15, 2024 08:26
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Pull Request Test Coverage Report for Build 11854718569Details
💛 - Coveralls |
amam-deriv
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unique approach, but left few comments
ameerul-deriv
approved these changes
Nov 15, 2024
Deploying deriv-utils with Cloudflare Pages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Multiple simultaneous requests to
cloudflare.com/cdn-cgi/trace
during app initialization causing console errors and unnecessary network calls.Solution
Implemented Promise caching in
getCountry
utility to deduplicate requests: