Ernest/ Add currency selection dropdown in Ads List and Advertiser Page #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update function to accept optional currency parameter for ad filtering. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Update function to accept optional currency parameter for ad filtering. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Update function to accept optional currency parameter for ad filtering. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Update API to accept account_currency and add currency filter #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Replace AdsAPI.getCurrencies with useAccountCurrencies hook #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Replace AdsAPI.getCurrencies with useAccountCurrencies hook #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
#VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
farrah-deriv
reviewed
Nov 4, 2025
| Number(advert.completed_order_amount || 0), | ||
| currency: accountCurrency, | ||
| }, | ||
| paymentMethods: advert.payment_methods || [], |
Collaborator
There was a problem hiding this comment.
is this change needed?
Collaborator
Author
There was a problem hiding this comment.
Reverted this change. It was unintentional.
farrah-deriv
reviewed
Nov 4, 2025
app/ads/page.tsx
Outdated
Comment on lines
82
to
88
| useEffect(() => { | ||
| if (accountCurrencies.length > 0 && !selectedCurrency) { | ||
| const defaultCurrency = accountCurrencies.find((c) => c.code === "USD")?.code || accountCurrencies[0]?.code || "" | ||
| setSelectedCurrency(defaultCurrency) | ||
| } | ||
| }, [accountCurrencies, selectedCurrency]) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
@farrah-deriv Here I am setting default currency to USD in case its available, else selecting the first available currency.
Update workflows, tests, and components for new changes. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Update workflows, tests, and components for new changes. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Update workflows, tests, components, and stylesheets. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Update workflows, tests, components, and global styles #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Eliminate duplicate logic handled in useAccountCurrencies hook. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Initialize default currency and trigger fetch on selection change #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Use first currency from accountCurrencies as fallback in fetch. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Use first currency from accountCurrencies as fallback #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Remove default currency useEffect and set default in fetchAds. #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Remove default currency useEffect and set default in fetchAds #VERCEL_SKIP Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Update workflows, tests, components, and README. Co-authored-by: null <120568427+ernest-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.