Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (Lending): withdraw basics #48

Merged
merged 4 commits into from
Dec 12, 2022
Merged

feat (Lending): withdraw basics #48

merged 4 commits into from
Dec 12, 2022

Conversation

antoncoding
Copy link
Contributor

@antoncoding antoncoding commented Dec 9, 2022 •
edited
Loading

Summary

  • withdraw by USDC amount. Basically a mirrored function of deposit
  • we might need a withdrawByCashAmount function to clear out balance in Account. Otherwise there will always be dust amount left in an account

Todo

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Add natspec for all functions / parameters
  • Ran forge snapshot
  • Ran forge fmt
  • Ran forge test
  • Triage Slither issues, and post uncertain ones in the PR
  • 100% test coverage on code changes

Slither Issues (Optional)

If you're unsure about a new issue reported by Slither, copy them here so others can verify as well.

@antoncoding antoncoding force-pushed the feat/lending-withdraw branch 2 times, most recently from 1ae45e4 to 40bae47 Compare December 12, 2022 03:44
@antoncoding antoncoding marked this pull request as draft December 12, 2022 05:49
@antoncoding antoncoding added the feature workstream feature label Dec 12, 2022
@antoncoding antoncoding marked this pull request as ready for review December 12, 2022 06:09
@antoncoding antoncoding changed the base branch from feat/lending-deposit to proto1-sprint1/lending December 12, 2022 06:16
LondonCalamari
LondonCalamari approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@LondonCalamari LondonCalamari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

joshpwrk
joshpwrk approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@joshpwrk joshpwrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshpwrk joshpwrk merged commit 1f863a2 into proto1-sprint1/lending Dec 12, 2022
@antoncoding antoncoding deleted the feat/lending-withdraw branch January 3, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpwrk joshpwrk joshpwrk approved these changes

@LondonCalamari LondonCalamari LondonCalamari approved these changes

Assignees
No one assigned
Labels
feature workstream feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoncoding @joshpwrk @LondonCalamari