Fix memory leaks. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove event handlers from `window` when the tooltip is not showing. - Get rid of component deconstruction remnants. `downgradeElements` was updated in dec 2015 to not actually do any downgrading, because at the time none of the components needed deconstruction. A memory leak was then added to the Tooltip component in May 2016. These changes to `downgradeElements` were problematic: - It still removes the `data-upgraded` attributes from dom elements, even though no deconstruction actually happened. This means that calling `upgradElement` again will double-upgrade the element. - the `createComponents_` array no longer serves any purpose.
claydiffrient
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windowwhen the tooltip is not showing.downgradeElementswas updated in dec 2015 to not actually do any downgrading, because at the time none of the components needed deconstruction. A memory leak was then added to the Tooltip component in May 2016.These changes to
downgradeElementswere problematic:data-upgradedattributes from dom elements, even though no deconstruction actually happened. This means that callingupgradElementagain will double-upgrade the element.createComponents_array no longer serves any purpose.