getting unreproducible initialization failures #93
Comments
|
Thanks a lot for going through the trouble of making a video! So if I get this correctly, the problem is that for some reason the move state is not entered consistently all of the time. So now I see two ways that this could go wrong:
In either case the solution revolves around the appropriate event being sent so a state change can happen. So as a first step I think we'll need to check that the event is indeed sent at the right time. As you have pointed out there isn't a lot to see in the C# debugger. This is because the C# scripts are just a very thin wrapper around the core library which is written in GDScript. So all the "magic" happens in GDScript land and is therefore invisible to the C# debugger (arguably there isn't really a lot to see on the GDScript side as well). Nevertheless, we have some debugging aids that can help with this.
There is a history panel showing what events were received and how the state chart reacted to this.
and then: // this is for debugging purposes so we can see when some event is received
private void OnEventReceived(StringName evt)
{
GD.Print("Event received: " + evt);
}I have created a small demo project showing all these options if you want to see it in action: I think with this we should be able to see what events go into the state chart and how it reacts to these and this will hopefully help in finding the root cause of the problem and coming up with a fix. |
derkork
added
bug
|
Thanks for the response. I think that it might be simpler as in that the state chart never entered the default state of the compound state. No default state, no animation gets started and nothing else happens. It is not consistent between starts of the application but it is consistent for every run of the application. meaning either it works for hundredths (thousands) of state charts, or it works for none. had to rig it a little different
good state
no code change between the two for reference, I got it to display like a healthbar. Using a SubViewport and a Sprite3d set to billboard. |
|
These screenshots are very interesting. I checked the initialization code of the state chart which looks like this: func _ready() -> void:
if Engine.is_editor_hint():
return
# check if we have exactly one child that is a state
if get_child_count() != 1:
push_error("StateChart must have exactly one child")
return
# check if the child is a state
var child:Node = get_child(0)
if not child is State:
push_error("StateMachine's child must be a State")
return
# initialize the state machine
_state = child as State
_state._state_init()
# enter the state
_state._state_enter.call_deferred()
# if we are in an editor build and this chart should be tracked
# by the debugger, create a debugger remote
if track_in_editor and OS.has_feature("editor"):
_debugger_remote = DebuggerRemote.new(self)So you can see that the only way for this to exit without printing an error would be if the state chart runs in the editor. Everything else prints an error message. But who knows, so I added a hard return directly at the start, so that not even the initialization code would run. This broke the state chart of course, but I saw a crucial difference between your screenshot of the state chart debugger and mine:
Mine shows at least the root node of the state chart, while yours shows nothing, not even the root node. Which leads me to believe that the state chart isn't even in the tree in the first place or it is deleted really quickly before anything visible can be done. Is there maybe a way through your logic that would trigger a deletion of the whole thing right at the beginning? Maybe you could add a breakpoint/print statements to the lines of code that |
|
It is not a race condition at the mob level. When this happens every mob has the same issue. not even every mob of the same scene type, every single one regardless of the scene code. My only QueueFree is in the Animation Finished and requires the die animation to play. And that in turn is also tied to the state chart so it is impossible to die. MortarBugView - Copy.tscn.txt Is there code that runs at the registration of the addon level before the instantiations? because it looks like it never got to the code that you shared. I do not have other Godot plugins; I reinstalled statechart 3/16 (unsure how to tell the version) I have 2 3rd party packages Godot 4.2.1 this is how the scene is instantiated
and then called like this in the root scene.
or it may spend some time on a queue before being added to the root scene. going to see if I can reproduce it on an other machine and/or w/o visual studio. |
|
btw happy to get you source code access, but I figure that I'd first reproduce it on an other machine. |
|
I think this is the behavior when it shows up inside Godot
|
|
This last screenshot doesn't look healthy. Do you have by any chance a |
|
No hits on [GlobalClass] |
|
Hmm it's really hard to say. I have a feeling this is something very small and simple but without seeing the full project or a reproducer it's really hard to investigate this. |
|
https://github.com/BasHamer/LAND-TRAINS changed it to public. There are no keys in there, if it gets keys I'll change it to private. It is currently set in a test mode (on scene Main property TargetDummy = true ), don't click the red door :) that will crash it. I'm in MST, happy to make time to get it up and running, just send me some time options. |
|
So I have it checked out locally and after fixing some problems with the main script (the camera wasn't working correctly and I got a lot of exceptions) I finally got it running. Thing is, though I cannot even reproduce it locally with this one. I ran it 30 times in a row and it worked 30 times in a row. So this positively screams "race condition" - which are the hardest to debug. I just need to find out where. I'm digging a bit deeper into the codebase to find out more. Also which exact version of Godot are you using? |
|
Hmm it's all pretty standard |
|
Godot_v4.2.1-stable_mono_win64 and yeah it is not consistent. This morning I'm not having much luck w/ triggering it, it took 40 ish minutes, and 10 of that was regular dev time vs hitting reload.. sorry about the exceptions, I missed a lot of those as they went to console, working on getting the console log clean. I'm glad it wasn't too bad to get running (no idea on the camera issue but I'm sure I'll encounter it once I try and get a playable build to friends.)
|
|
a few notes; the lines that say I can find no info on Exception thrown at 0x00007FF8665A5B0C in Godot_v4.2.1-stable_mono_win64.exe: Microsoft C++ exception: CommonUtil::CHResultExceptionImpl at memory location 0x0000009FDEDFA070. |
|
The error output doesn't really make sense. It says it cannot find the |
|
ok thanks for all your help; I'll be back if I can find more information. I created an export and it ran. I deleted the folder and will look after work. It is likely that I ended up with weird stuffs as this is the first Godot project I have created. I'll report back if it happens again or if it disappeared. |
|
24 hours w/o the issue, tempting fate by writing this intentionally. |
|
yeah still happening :/ going to try and see if my laptop can reproduce it. if not then I'm going to ignore it until I get bug reports from users. ** reproduced it on my laptop (also reproduced the camera issue you mentioned). Still going to ignore it as it is quick to catch and I don't know if it will happen in the exports. Thanks again for all the help |
|
Thanks for reporting back! Well that still isn't nice but given the error messages we've seen and the fact that it can be fixed by cleaning the |
derkork
added
wontfix
when it fails then it fails for all initializations.
below is my Godot setup and the code. When this condition occurs I find that the mob never enters Move State. None of the mobs do. When the bug is not happening everything works great. I've been chasing this thing down for a while now trying to figure out (6+ weeks) where the race condition could be and I'm getting pretty confident that it is in the Compound State. When looking in the Debugger (C#) I have a hard time telling what is going on as the StateChart and Compound State show as Node and I can't figure out how to view the Compound State state.
`public override void _Ready()
{
...
StateChart = StateChart.Of(GetNode("StateChart"));
...
}
internal void _on_spawn_state_entered()
{
AnimationPlayer.Play("spawn");
}
`
video should be ready in 40 min https://youtu.be/beAuaZE9S_g (unlisted)
The text was updated successfully, but these errors were encountered: