Generated code doesn't work for Firestore

[xJonathanLEI]

The Firestore API requires building request URLs in the format of v1/{parent}/databases, where parent takes the form of projects/{project_id}.

The code generated by this generator URL-encodes this parent param like so:

let rel_path = format!(
    "v1/{parent}/databases",
    parent = percent_encode(format!("{}", params.parent).as_bytes(), NON_ALPHANUMERIC)
);
let path = self.format_path(rel_path.as_str());

Therefore, the request path becomes:

/v1/projects%2Fproject_id/databases

whereas it should be:

/v1/projects/project_id/databases

This mis-handling of URL is causing 404 errors.

[xJonathanLEI]

For context, the code was generated with:

./generate.py --apis=firestore:v1

[dermesser]

I will try to take a look soon. In the meantime, you're welcome to try it out yourself -- but I understand if it's not an option, the python code can be a bit complex :)

[dermesser]

Sorry for forgetting so long about this - is this still an issue for you, or have you found a workaround?

[xJonathanLEI]

Hey thanks for picking this up again :)

I haven't tested but I guess the issue must still be there? Given there has been no code update since the issue was created.

I have been using a workaround: modifying the generated code to not do the percent_encode on parent and it works well (though it might only work when there's no special character in project_id I guess).

[dermesser]

Got it - I was asking in case you'd given up on this code and rolled something yourself :)

I guess a quick fix is to attempt encoding anything but the slash characters; I am also not sure why it doesn't work in the first place, as I was under the impression that url-encoded characters should be decoded (but I guess Google takes some parameters literally). The hope would be that this doesn't break another API which can't deal with unencoded slashes in the wrong place :-]