Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write instead of write_all causes very rare failures #19

Closed
mfro opened this issue Feb 14, 2021 · 1 comment
Closed

write instead of write_all causes very rare failures #19

mfro opened this issue Feb 14, 2021 · 1 comment

Comments

@mfro
Copy link

mfro commented Feb 14, 2021

In the very rare cases where the underlying stream can only accept a small number of bytes for the first write call, the VarIntWriter functions will behave incorrectly, discarding the bytes that aren't written in the first call. I believe these calls should be replaced with write_all

dermesser added a commit that referenced this issue Feb 15, 2021
dermesser added a commit that referenced this issue Feb 15, 2021
dermesser added a commit that referenced this issue Feb 15, 2021
@dermesser
Copy link
Owner

Thank you, I've implemented a backwards-compatible fix for this and released new versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants