Replace unaligned pointer deref with read_unaligned #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deference a pointer, it must be correctly aligned for
T
. Since there's no alignment check at runtime or enforcement by the type system, this code must useread_unaligned
to read the integer's bytes out of the slice. Code like this tends to work fine on x86 because it generally supports unaligned memory access, but may fault on other architectures.This problem can be demonstrated by running
cargo miri test
before this PR.