Skip to content

Commit

Permalink
📝 http:// -> https://
Browse files Browse the repository at this point in the history
whitespace tweak
  • Loading branch information
desandro committed Feb 18, 2022
1 parent 26d823c commit b7181ac
Show file tree
Hide file tree
Showing 8 changed files with 42 additions and 43 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ $('#container').imagesLoaded( {
);
```

`.imagesLoaded()` returns a [jQuery Deferred object](http://api.jquery.com/category/deferred-object/). This allows you to use `.always()`, `.done()`, `.fail()` and `.progress()`.
`.imagesLoaded()` returns a [jQuery Deferred object](https://api.jquery.com/category/deferred-object/). This allows you to use `.always()`, `.done()`, `.fail()` and `.progress()`.

``` js
$('#container').imagesLoaded()
Expand Down Expand Up @@ -126,7 +126,7 @@ imagesLoaded( '#container', { background: true }, function() {
});
```

[See jQuery demo](http://codepen.io/desandro/pen/pjVMPB) or [vanilla JS demo](http://codepen.io/desandro/pen/avKooW) on CodePen.
[See jQuery demo](https://codepen.io/desandro/pen/pjVMPB) or [vanilla JS demo](https://codepen.io/desandro/pen/avKooW) on CodePen.

Set to a selector string like `{ background: '.item' }` to detect when the background images of child elements have loaded.

Expand All @@ -142,7 +142,7 @@ imagesLoaded( '#container', { background: '.item' }, function() {
});
```

[See jQuery demo](http://codepen.io/desandro/pen/avKoZL) or [vanilla JS demo](http://codepen.io/desandro/pen/vNrBGz) on CodePen.
[See jQuery demo](https://codepen.io/desandro/pen/avKoZL) or [vanilla JS demo](https://codepen.io/desandro/pen/vNrBGz) on CodePen.

## Events

Expand Down Expand Up @@ -278,7 +278,7 @@ webpack main.js bundle.js

## Browserify

imagesLoaded works with [Browserify](http://browserify.org/).
imagesLoaded works with [Browserify](https://browserify.org/).

``` bash
npm install imagesloaded --save
Expand Down Expand Up @@ -322,4 +322,4 @@ nvm use

## MIT License

imagesLoaded is released under the [MIT License](http://desandro.mit-license.org/). Have at it.
imagesLoaded is released under the [MIT License](https://desandro.mit-license.org/). Have at it.
16 changes: 8 additions & 8 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

### Reduced test case required

All bug reports and problem issues require a [**reduced test case**](http://css-tricks.com/reduced-test-cases/).
All bug reports and problem issues require a [**reduced test case**](https://css-tricks.com/reduced-test-cases/).

+ A reduced test case clearly demonstrates the bug or issue.
+ It contains the bare minimum HTML, CSS, and JavaScript required to demonstrate the bug.
+ A link to your production site is **not** a reduced test case.

Create a test case by forking a [CodePen demos](http://codepen.io/desandro/pens/tags/?selected_tag=imagesloaded-docs).
Create a test case by forking a [CodePen demos](https://codepen.io/desandro/pens/tags/?selected_tag=imagesloaded-docs).

+ [progress with jQuery](http://codepen.io/desandro/pen/bIFyl)
+ [progress with vanilla JS](http://codepen.io/desandro/pen/hlzaw)
+ [`{ background: true }` with jQuery](http://codepen.io/desandro/pen/pjVMPB)
+ [`{ background: true }` with vanilla JS](http://codepen.io/desandro/pen/avKooW)
+ [`{ background: '.selector' }` with jQuery](http://codepen.io/desandro/pen/avKoZL)
+ [`{ background: '.selector' }` with vanilla JS](http://codepen.io/desandro/pen/vNrBGz)
+ [progress with jQuery](https://codepen.io/desandro/pen/bIFyl)
+ [progress with vanilla JS](https://codepen.io/desandro/pen/hlzaw)
+ [`{ background: true }` with jQuery](https://codepen.io/desandro/pen/pjVMPB)
+ [`{ background: true }` with vanilla JS](https://codepen.io/desandro/pen/avKooW)
+ [`{ background: '.selector' }` with jQuery](https://codepen.io/desandro/pen/avKoZL)
+ [`{ background: '.selector' }` with vanilla JS](https://codepen.io/desandro/pen/vNrBGz)

Providing a reduced test case is the best way to get your issue addressed. They help you point out the problem. They help me verify and debug the problem. They help others understand the problem. Without a reduced test case, your issue may be closed.
5 changes: 2 additions & 3 deletions imagesloaded.js
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,8 @@ Background.prototype.confirm = function( isLoaded, message ) {

ImagesLoaded.makeJQueryPlugin = function( jQuery ) {
jQuery = jQuery || window.jQuery;
if ( !jQuery ) {
return;
}
if ( !jQuery ) return;

// set local variable
$ = jQuery;
// $().imagesLoaded()
Expand Down
8 changes: 4 additions & 4 deletions sandbox/background/css/background.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}

.orange-tree {
background: url('http://i.imgur.com/bwy74ok.jpg');
background: url('https://i.imgur.com/bwy74ok.jpg');
background-size: cover;
}

Expand All @@ -18,9 +18,9 @@

.multi1 {
background:
url("http://i.imgur.com/ZAVN3.png"),
url('http://i.imgur.com/6UdOxeB.png') bottom right,
url(http://i.imgur.com/LkmcILl.jpg);
url("https://i.imgur.com/ZAVN3.png"),
url('https://i.imgur.com/6UdOxeB.png') bottom right,
url(https://i.imgur.com/LkmcILl.jpg);
background-size: cover;
}

Expand Down
4 changes: 2 additions & 2 deletions sandbox/progress/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@

li.is-loading {
background-color: black;
background-image: url('http://desandro.github.io/imagesloaded/assets/loading.gif');
background-image: url('https://desandro.github.io/imagesloaded/assets/loading.gif');
}

li.is-broken {
background-image: url('http://desandro.github.io/imagesloaded/assets/broken.png');
background-image: url('https://desandro.github.io/imagesloaded/assets/broken.png');
background-color: #be3730;
width: 120px;
}
Expand Down
8 changes: 4 additions & 4 deletions test/css/tests.css
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ img {
}

.bg-box.tulip {
background: url('http://i.imgur.com/9xYjgCk.jpg');
background: url('https://i.imgur.com/9xYjgCk.jpg');
background-size: cover;
}

Expand All @@ -35,8 +35,8 @@ img {

.bg-box.multi {
background:
url("http://i.imgur.com/ZAVN3.png"),
url('http://i.imgur.com/6UdOxeB.png') bottom right,
url("https://i.imgur.com/ZAVN3.png"),
url('https://i.imgur.com/6UdOxeB.png') bottom right,
url(https://picsum.photos/601/401/?random);
background-size: cover;
}
Expand All @@ -46,6 +46,6 @@ img {
}

.bg-box.gulls {
background-image: url('http://i.imgur.com/qKhkOKC.jpg');
background-image: url('https://i.imgur.com/qKhkOKC.jpg');
background-size: cover;
}
22 changes: 11 additions & 11 deletions test/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ <h1>imagesLoaded tests</h1>
<h2>Basics</h2>

<div id="basics">
<img src="http://i.imgur.com/xrQHn.jpg" />
<img src="http://i.imgur.com/b3fBJ.jpg" />
<img src="http://i.imgur.com/xmSh2.jpg" />
<img src="http://i.imgur.com/iIpJm.jpg" />
<img src="http://i.imgur.com/cvZZl10.gif" />
<img src="https://i.imgur.com/xrQHn.jpg" />
<img src="https://i.imgur.com/b3fBJ.jpg" />
<img src="https://i.imgur.com/xmSh2.jpg" />
<img src="https://i.imgur.com/iIpJm.jpg" />
<img src="https://i.imgur.com/cvZZl10.gif" />
</div>

<img id="mario-with-shell" src="http://i.imgur.com/ZAVN3.png" >
<img id="mario-with-shell" src="https://i.imgur.com/ZAVN3.png" >

<h2>Locals</h2>

Expand Down Expand Up @@ -74,17 +74,17 @@ <h2>no images</h2>
<h2>jQuery success</h2>

<div id="jquery-success">
<img src="http://i.imgur.com/YbYCPFF.png" />
<img src="http://i.imgur.com/6UdOxeB.png" />
<img src="http://i.imgur.com/qd8G15D.png" />
<img src="https://i.imgur.com/YbYCPFF.png" />
<img src="https://i.imgur.com/6UdOxeB.png" />
<img src="https://i.imgur.com/qd8G15D.png" />
</div>

<h2>jQuery fail</h2>

<div id="jquery-fail">
<img src="http://i.imgur.com/xmSh2.jpg" />
<img src="https://i.imgur.com/xmSh2.jpg" />
<img src="img/bowser-jr.jpg" />
<img src="http://i.imgur.com/ZAVN3.png">
<img src="https://i.imgur.com/ZAVN3.png">
<img src="img/not-there.jpg" />
<img src="foobar.jpg" />
</div>
Expand Down
12 changes: 6 additions & 6 deletions test/unit/append.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
QUnit.test( 'append', function( assert ) {
let imgUrls = [
'http://i.imgur.com/bwy74ok.jpg',
'http://i.imgur.com/bAZWoqx.jpg',
'http://i.imgur.com/PgmEBSB.jpg',
'http://i.imgur.com/aboaFoB.jpg',
'http://i.imgur.com/LkmcILl.jpg',
'http://i.imgur.com/q9zO6tw.jpg',
'https://i.imgur.com/bwy74ok.jpg',
'https://i.imgur.com/bAZWoqx.jpg',
'https://i.imgur.com/PgmEBSB.jpg',
'https://i.imgur.com/aboaFoB.jpg',
'https://i.imgur.com/LkmcILl.jpg',
'https://i.imgur.com/q9zO6tw.jpg',
];

// create images
Expand Down

0 comments on commit b7181ac

Please sign in to comment.