Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly check for dict values in JWTs #28

Merged
merged 2 commits into from
Nov 6, 2022
Merged

Properly check for dict values in JWTs #28

merged 2 commits into from
Nov 6, 2022

Conversation

omercnet
Copy link
Member

@omercnet omercnet commented Nov 6, 2022

This solves and issue where if name or role are empty a KeyError is raised

@omercnet omercnet requested a review from guyp-descope November 6, 2022 18:07
@omercnet omercnet requested review from gshriki and slavikm November 6, 2022 18:13
slavikm
slavikm approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@slavikm slavikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pesky keys that don't exist :-)

@omercnet omercnet merged commit 21acdac into main Nov 6, 2022
@omercnet omercnet deleted the fix/jwtdicts branch November 6, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyp-descope guyp-descope guyp-descope approved these changes

@slavikm slavikm slavikm approved these changes

@gshriki gshriki Awaiting requested review from gshriki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omercnet @slavikm @guyp-descope