New issue

Jump to bottom

Change access key and refresh session to POST #64

Merged

dorsha merged 1 commit into main from change-access-key-exchange-to-post

Oct 20, 2022

+2 −2

Member

dorsha commented Oct 20, 2022

No description provided.


          Change access key and refresh session to POST

5ffab61

dorsha requested review from slavikm and aviadl

October 20, 2022 18:49

github-actions bot commented Oct 20, 2022 •

edited

Loading

Coverage Report

File	Stmts	Miss	Cover	Missing
descope
auth.py	256	30	88%	55, 133, 136–149, 161, 222–223, 228–234, 363, 403, 446, 471–472, 489–496
descope_client.py	91	5	95%	172, 237, 252–257
descope/authmethod
magiclink.py	116	8	93%	37, 75, 120–124, 144–148
otp.py	83	13	84%	60–62, 142–144, 175, 197–203
TOTAL	798	56	93%

Tests	Skipped	Failures	Errors	Time
69	0 💤	15 ❌	0 🔥	4.818s ⏱️

dorsha requested a review from guyp-descope

October 20, 2022 18:55

Contributor

guyp-descope commented Oct 20, 2022

@dorsha please adjust the tests as well.

aviadl approved these changes

View reviewed changes

dorsha merged commit 44620c3 into main

dorsha deleted the change-access-key-exchange-to-post branch

October 20, 2022 20:31

Member Author

dorsha commented Oct 20, 2022

oh strange, build passed, it is hard to understand that, @guyp-descope need to make sure build fails..

Contributor

guyp-descope commented Oct 20, 2022

@dorsha yea I know. @omercnet and me worked today to fix this:
#62
but first we need to fix all the tests

Member

aviadl commented Oct 20, 2022

@guyp-descope what do you mean ?
what happened to all the tests?

Contributor

guyp-descope commented Oct 20, 2022

two things:

we had a bug that our build didnt failed when test failed (this is what omer pr is fixing)
found now that the tests failed due to upgrade of the email_validator package which now check for real dns record (so we need to pass a flag to disable this new behavior (the upgrade of the package was merged due to the first bug))
Ill fix it tomorrow.

descope bot referenced this pull request in descope/django-descope


          fix(deps): update dependency descope to v0.3.0 (#32)

d397687

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [descope](https://descope.com/)
([source](https://togithub.com/descope/python-sdk)) | dependencies |
minor | `0.2.0` -> `==0.3.0` |
| [descope](https://descope.com/)
([source](https://togithub.com/descope/python-sdk)) | | minor |
`==0.2.0` -> `==0.3.0` |

---

### Release Notes

<details>
<summary>descope/python-sdk</summary>

###
[`v0.3.0`](https://togithub.com/descope/python-sdk/releases/tag/0.3.0)

[Compare
Source](https://togithub.com/descope/python-sdk/compare/0.2.0...0.3.0)

##### What's Changed

- Change exchange to POST by
[@&#8203;dorsha](https://togithub.com/dorsha) in
[https://github.com/descope/python-sdk/pull/63](https://togithub.com/descope/python-sdk/pull/63)
- Change access key and refresh session to POST by
[@&#8203;dorsha](https://togithub.com/dorsha) in
[https://github.com/descope/python-sdk/pull/64](https://togithub.com/descope/python-sdk/pull/64)
- 1. adjust email_validator for the new version (disable call for dns q…
by [@&#8203;guyp-descope](https://togithub.com/guyp-descope) in
[https://github.com/descope/python-sdk/pull/65](https://togithub.com/descope/python-sdk/pull/65)
- fix: use cov xml file for result by
[@&#8203;omercnet](https://togithub.com/omercnet) in
[https://github.com/descope/python-sdk/pull/62](https://togithub.com/descope/python-sdk/pull/62)
- chore(deps): update dependency black to v22.10.0 by
[@&#8203;descope](https://togithub.com/descope) in
[https://github.com/descope/python-sdk/pull/67](https://togithub.com/descope/python-sdk/pull/67)
- Extend API to support custom claims by
[@&#8203;aviadl](https://togithub.com/aviadl) in
[https://github.com/descope/python-sdk/pull/68](https://togithub.com/descope/python-sdk/pull/68)
- Change SAML start to be post by
[@&#8203;dorsha](https://togithub.com/dorsha) in
[https://github.com/descope/python-sdk/pull/70](https://togithub.com/descope/python-sdk/pull/70)
- Change oauth authorize to be post by
[@&#8203;dorsha](https://togithub.com/dorsha) in
[https://github.com/descope/python-sdk/pull/71](https://togithub.com/descope/python-sdk/pull/71)
- Fix oauth/saml start to be POST with query params by
[@&#8203;dorsha](https://togithub.com/dorsha) in
[https://github.com/descope/python-sdk/pull/72](https://togithub.com/descope/python-sdk/pull/72)
- Add useful headers by [@&#8203;dorsha](https://togithub.com/dorsha) in
[https://github.com/descope/python-sdk/pull/73](https://togithub.com/descope/python-sdk/pull/73)
- Stepup take 2 by [@&#8203;aviadl](https://togithub.com/aviadl) in
[https://github.com/descope/python-sdk/pull/74](https://togithub.com/descope/python-sdk/pull/74)
- Adjust jwt response for access key with authz by
[@&#8203;guyp-descope](https://togithub.com/guyp-descope) in
[https://github.com/descope/python-sdk/pull/75](https://togithub.com/descope/python-sdk/pull/75)
- fix(deps): update dependency cryptography to v38.0.3 \[security] by
[@&#8203;descope](https://togithub.com/descope) in
[https://github.com/descope/python-sdk/pull/76](https://togithub.com/descope/python-sdk/pull/76)
- fix(deps): update dependency pyjwt to v2.6.0 by
[@&#8203;descope](https://togithub.com/descope) in
[https://github.com/descope/python-sdk/pull/77](https://togithub.com/descope/python-sdk/pull/77)
- chore(deps): update dependency pytest-cov to v4 by
[@&#8203;descope](https://togithub.com/descope) in
[https://github.com/descope/python-sdk/pull/69](https://togithub.com/descope/python-sdk/pull/69)
- chore(deps): update dependency pytest to v7.2.0 by
[@&#8203;descope](https://togithub.com/descope) in
[https://github.com/descope/python-sdk/pull/79](https://togithub.com/descope/python-sdk/pull/79)
- Add webauthn SignUpOrIn function by
[@&#8203;shilgapira](https://togithub.com/shilgapira) in
[https://github.com/descope/python-sdk/pull/80](https://togithub.com/descope/python-sdk/pull/80)
- Have both logout and logout_all as optinos by
[@&#8203;slavikm](https://togithub.com/slavikm) in
[https://github.com/descope/python-sdk/pull/81](https://togithub.com/descope/python-sdk/pull/81)
- Add MFA support by [@&#8203;aviadl](https://togithub.com/aviadl) in
[https://github.com/descope/python-sdk/pull/82](https://togithub.com/descope/python-sdk/pull/82)
- chore(deps): update dependency liccheck to v0.7.3 by
[@&#8203;descope](https://togithub.com/descope) in
[https://github.com/descope/python-sdk/pull/83](https://togithub.com/descope/python-sdk/pull/83)
- Management by [@&#8203;itaihanski](https://togithub.com/itaihanski) in
[https://github.com/descope/python-sdk/pull/84](https://togithub.com/descope/python-sdk/pull/84)
- Add issuer support as url by
[@&#8203;dorsha](https://togithub.com/dorsha) in
[https://github.com/descope/python-sdk/pull/85](https://togithub.com/descope/python-sdk/pull/85)
- Get management key from env var or config params by
[@&#8203;shilgapira](https://togithub.com/shilgapira) in
[https://github.com/descope/python-sdk/pull/87](https://togithub.com/descope/python-sdk/pull/87)
- Enchanted link support by
[@&#8203;aviadl](https://togithub.com/aviadl) in
[https://github.com/descope/python-sdk/pull/86](https://togithub.com/descope/python-sdk/pull/86)
- Ensure management key is set before passing calls to management APIs
by [@&#8203;shilgapira](https://togithub.com/shilgapira) in
[https://github.com/descope/python-sdk/pull/90](https://togithub.com/descope/python-sdk/pull/90)
- Set localhost as default base_url (instead of prod link) by
[@&#8203;guyp-descope](https://togithub.com/guyp-descope) in
[https://github.com/descope/python-sdk/pull/88](https://togithub.com/descope/python-sdk/pull/88)
- update poetry lockfile by
[@&#8203;omercnet](https://togithub.com/omercnet) in
[https://github.com/descope/python-sdk/pull/89](https://togithub.com/descope/python-sdk/pull/89)

##### New Contributors

- [@&#8203;itaihanski](https://togithub.com/itaihanski) made their first
contribution in
[https://github.com/descope/python-sdk/pull/84](https://togithub.com/descope/python-sdk/pull/84)

**Full Changelog**:
descope/python-sdk@0.2.0...0.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzguMSIsInVwZGF0ZWRJblZlciI6IjMyLjIzOC4xIn0=-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet