Fix extension not showing up in the Settings Editor #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
changed the title
This fixes an issue where settings were not available until a notebook was opened.
krassowski
force-pushed
the
fix-settings-init
branch
from
35bcaca to
ddd6ff0
Compare
|
Is this PR ready for review? |
Yes, I believe so. |
mlucool
approved these changes
May 17, 2024
This was referenced Sep 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
activatefunction to avoid the delay in loading the settings until the first notebook is opened; this also improves the performance when opening notebook as the loading logic is not unnecessarily invoked multiple times anymore