Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not yet support linking to paths (JupyterLab 4.1+) #18

Closed
krassowski opened this issue Dec 11, 2023 · 1 comment
Closed

Does not yet support linking to paths (JupyterLab 4.1+) #18

krassowski opened this issue Dec 11, 2023 · 1 comment

Comments

@krassowski
Copy link
Contributor

The upcoming JupyterLab 4.1 will support linking to paths. jupyterlab-skip-traceback replaces application/vnd.jupyter.error renderer it disables linking. This is because JupyterLab 4.1 defines a new renderError function which enables opening files from tracebacks but jupyterlab-skip-traceback uses the old renderText:

jupyterlab-skip-traceback/src/SkipTracebackWidget.ts

Line 103 in b6cd79c

const rt = renderText({

This will need to be swapped in a future version to support linking to paths.
@krassowski krassowski mentioned this issue Dec 19, 2023
Merged
@mlucool
Copy link
Member

mlucool commented Apr 1, 2024

Fixed in #20 and released in 5.1.0

@mlucool mlucool closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlucool @krassowski