Support path links (JupyterLab 4.1+) and fix CI #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI: remove unused `[test]`, bump jupyterlab version Add missing setup.py Remove unused manifest file Remove unused travis config Fix incomplete migration to hatch versioning Update lab version in pyproject Make the python package importable
krassowski
force-pushed
the
fix/lab-4.1-compat-and-CI
branch
from
cbcf825 to
57d909a
Compare
|
Looks like I missed this. Should I still review it? |
|
Yes, this PR is still needed to support linking to paths. |
|
Link failure is expected until I release. Thanks @krassowski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
renderErrorfunctionality needslinkerandresolveroptions; instead of threading them individually this PR passes fullIRenderMime.IRendererOptionsto the render functions, which has the added benefit of also passing thetranslatorobjecttravis.yml) or incorrectly committed (_version.py) files.Currently the CI does not run, nor pass on the default
masterbranch. This PR fixes the CI but does not make it run onmasterin case if a decision to rename tomainis taken; this is tracked in #19.Please let me know if you prefer this to be two separate pull requests.