Make the hashtable dataset exactly as big as it needs to be #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was always filled with 0s to be default_chunk_size aligned, but this is no longer necessary now that we write to it once at the end. The chunk_size resizing is still used for the in-memory NumPy array. This makes the hashtables much smaller on disk for datasets without many chunks. This keeps the largest_index attribute for backwards compatibility with hash tables that were created before this change (which will automatically be resized down the next time they are written to). It also fixes the documentation of largest_index. Fixes deshaw#205.
|
Looks good to me. What are the file sizes now for the example code in #205 ? |
|
Before data.h5 was 205K, with this PR it is 11K. |
Closed
asmeurer
added a commit
that referenced
this pull request
Sep 30, 2021
Fix a bug with the hashtable introduced by #206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was always filled with 0s to be default_chunk_size aligned, but
this is no longer necessary now that we write to it once at the end. The
chunk_size resizing is still used for the in-memory NumPy array.
This makes the hashtables much smaller on disk for datasets without many
chunks.
This keeps the largest_index attribute for backwards compatibility with hash
tables that were created before this change (which will automatically be
resized down the next time they are written to). It also fixes the
documentation of largest_index.
Fixes #205.