Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta XML for Sym 2.6 #8

Closed
DavidOliver opened this issue Mar 2, 2016 · 6 comments
Closed

Meta XML for Sym 2.6 #8

DavidOliver opened this issue Mar 2, 2016 · 6 comments
Assignees
Milestone

Comments

@DavidOliver
Copy link
Contributor

Hi. Just reporting that it seems to work fine with Symphony 2.6. Is the XML update just a case of adding a max attribute to the last release?

@designermonkey
Copy link
Owner

Hi @DavidOliver I'll happily take a PR, but this is no longer supported by me. I should offer it to the Symphonists really.

@DavidOliver
Copy link
Contributor Author

Hi @designermonkey. Hope you're well!

I was just looking at the schema in order to make a PR, and I would have thought that as no max attribute is present it should show as being compatible with all versions from 2.2 up. @nitriques?

@nitriques
Copy link

Hey John, I hope you are doing well. If you wish to transfer the repo to the symphonists account it would be cool. Thanks.

@twiro
Copy link
Collaborator

twiro commented Mar 3, 2016

I was just looking at the schema in order to make a PR, and I would have thought that as no max attribute is present it should show as being compatible with all versions from 2.2 up. @nitriques?

@DavidOliver - you might want to give this discussion a read. I'll try to sum that up and put it in the repos readme as soon as I'll find the time.

John: I'll happily take a PR, but this is no longer supported by me. I should offer it to the Symphonists really.

@designermonkey - Would be great if you could follow the brandnew guide for transferring & adopting extension-repos. We set up the "Symphony Extensions Network"-repo to help organizing the extension ecosystem and transferring repos is the first task I've set up a kind of "best practice guide" for...

@DavidOliver - want to adopt the extension? ;)

@DavidOliver
Copy link
Contributor Author

you might want to give this discussion a read.

That was helpful - thanks.

want to adopt the extension? ;)

I've had a quick look through the code, and while I can't claim to understand all of it I'm willing to have a go if you like.

@twiro twiro self-assigned this Jan 29, 2018
@twiro twiro added this to the 1.2.0 milestone Jan 29, 2018
@twiro twiro mentioned this issue Jan 29, 2018
@twiro
Copy link
Collaborator

twiro commented Jan 29, 2018

I improved compatibility, readme and meta data and published a new release:

Thanks for giving me access @designermonkey :)

@twiro twiro closed this as completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants