-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display of version compatibility #4
Comments
This is how I understand the description in the official schema documentation too (though it's not that clear on that point), but in fact the current behavior of displaying compatibility might be the better one with regards to long-term reliability of extensions listings: Right now an extension seems to be marked as incompatible with each new minor release unless explicitly stated otherwise. This rather strict method might automatically mark extensions as incompatible though they're actually working with a newer minor relase, but this looks like the lesser of two evils compared to the other option: having a list full of "compatible" extensions that actually don't work. This would be the case if we'd follow the contrary method - mark an extension as compatible with each new minor release unless explicitly stated otherwise. This would result in a quite green Compatibility Matrix simply because lots of old and unmaintained extensions don't have reliable As minor version updates of Symphony don't get released too often I prefer the strict method that's currently used, but maybe we can do better in engaging extension-developers to test and update the compatibility settings of their actively maintained extensions after minor releases (think of extension-hackathons). If we could agree on a kind of "best practices workflow" regarding how extension developers should treat this topic in the long run this might also make a useful addition to (the upcoming) readme of this repo. |
Following semver, this is not the right thing to do. But since we can't enforce it (and since Sym's API did change from minor version to another, we must keep it like we have). The simplest thing a developer can do is add the max attribute. |
So de facto symphonyextensions.com is doing it wrong (according to semver) because Symphony itself was doing it wrong (according to semver). But as we switched to semver with Symphony 2.5.0 one should expect that extensions that are compatible with that version will (theoretically) stay compatible with all following 2.X-releases - right? So wouldn't it be best to use the wildcard syntax 2.X.X as
This way extension developers wouldn't have to set up a new "yes-its-still-compatible"-release for each minor update of Symphony and actually benefit from the advantages of semver. @animaux - could you give that a try? |
See symphonists/symphony-extensions-network#4 (comment) ecomment-185103150
Ok, tried that. |
Yup.
Sadly, no: This will only be possible with 3.0.0
No since it would mean that it's compatible with 2.1 as well. (which clearly isn't). But after 3.0.0, yeah, we should.
Yeah for sure! |
One thing that could be done quickly would be to hide deprecated extension in the matrix... |
|
Great. |
That's cool and good to know!
But extensions with a But combining So my proposal was to encourage extension developers to make use of |
This would need some testing, but yeah, that's what should happen!
Should be!
That's the problem.... It would need a lot of change to actually do this. |
So for extensions which have an accurate Am I right in thinking that from now on, semver minor releases (e.g., Sym 2.7) should not break any extensions that work with Sym 2.5 (and 2.6)? |
@DavidOliver yes and yes! |
That for sure - but I think writing down some guidelines and best practices will definitively help encouraging developers to take action and make it easier for them to help improving the symphony-extension-ecosystem! This discussion alone seems to have done that to a certain extent ;) So thanks a lot to everyone participating and spreading the word!
Great! So as we agree upon that now I will try to add this info/recommendation to the readme in the next days - that way we will have a kind of "official reference" that can be linked to whenever the discussion comes up for a specific extension... will close this issue after the readme is updated. |
Yup! Thanks @twiro |
In
lang_german
version 2.1.0 it states Symphony 2.4.0 as minimum requirement. Thus it should be shown as compatible with Symphony 2.5.x as well if not stated otherwise by some newer version.But instead it says Symphony 2.5.x is not compatible.
The text was updated successfully, but these errors were encountered: