Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legendre nnls #287

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Legendre nnls #287

wants to merge 7 commits into from

Commits on Feb 27, 2024

  1. Modified archetypes using BVLS to add -1*all legendre terms to the basis

    vector (in tdata) so that NNLS can be used instead of BVLS.
    
    Fixed bug when ValueError excepted in rebinning
    craigwarner-ufastro committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c4132a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Modify prior array in prior_on_coeffs to include cross-terms for

    negative legendre terms.  Refactored a little to clean up.
    
    For archetypes with legendre terms, NNLS is now actually used with
    additional terms of -1*each legendre term so that we can use the faster
    NNLS to get the same result as BVLS.
    craigwarner-ufastro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a660106 View commit details
    Browse the repository at this point in the history
  2. Only use additional negative legendre terms and NNLS when in GPU mode

    because on CPU, the additional computation time for the larger array
    sizes dominates any time savings of NNLS vs BVLS
    craigwarner-ufastro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7911c5b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    bbf187b View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Moved as much logic as possible related to using NNLS with extra

    negative legendre terms on the GPU in lieu of BVLS into
    per_camera_coeff_with_least_square_batch.  Moved prior_on_coeffs into
    zscan.py, called from within per_camera_coeff_with_least_square_batch.
    Pass prior_sigma, a scalar, insted of the array from fitz to archetypes.
    
    Bug fix on case where only some object types, not all, have an
    archetype.
    craigwarner-ufastro committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    1ac311a View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Compress output COEFF when using BVLS-NNLS trick to remove legendre

    terms with 0 coefficients and make the coeffs negative for negative
    terms.
    
    Refactored to remove the last bit of the BVLS-NNLS trick from
    archetypes.py and zfind.py by passing binned instead of tdata to
    per_camera_coeff_with_least_square_batch.
    craigwarner-ufastro committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d1b7b8f View commit details
    Browse the repository at this point in the history
  2. Refactor to bring more in-line with main where the conflicts mostly

    involve using a list of bands instead of ncam to be more general.
    craigwarner-ufastro committed May 9, 2024
    Configuration menu
    Copy the full SHA
    fd76617 View commit details
    Browse the repository at this point in the history