Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix max_velo_diff for archetypes #302

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix max_velo_diff for archetypes #302

merged 1 commit into from
Apr 29, 2024

Conversation

sbailey
Copy link
Collaborator

@sbailey sbailey commented Apr 29, 2024

This PR is a followup to #300 which set max_velo_diff for spectype=STAR differently than GALAXY and QSO, but didn't handle the archetype case where spectype is a list of strings instead of a single string. This test command used to fail but now passes with this PR:

srun -n 4 --gpu-bind=map_gpu:3,2,1,0 --cpu-bind=cores rrdesi_mpi --gpu -n 10 \
  -i $CFS/desi/spectro/redux/iron/tiles/cumulative/80605/20210205/coadd-6-80605-thru20210205.fits \
  --archetypes /global/cfs/cdirs/desi/users/abhijeet/new-archetypes/rrarchetype-galaxy.fits \
  --model $SCRATCH/redrock/rrmodel-test.fits \
  -o $SCRATCH/redrock/redrock-test.fits

I also verified that removing the --archetypes option and running in non-archetype mode also continues to work.

@coveralls
Copy link

Coverage Status

coverage: 39.09% (+0.06%) from 39.033%
when pulling 4c845bc on velodiff_archetypes
into ae069fa on main.

@sbailey sbailey merged commit f7f95e5 into main Apr 29, 2024
12 checks passed
@sbailey sbailey deleted the velodiff_archetypes branch April 29, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants