Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insist that FITMETHOD is a 4-string from the moment NONE is added #303

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

geordie666
Copy link
Contributor

This PR fixes issue #301 by enforcing that the FITMETHOD column can hold strings of length 4 from the moment the string NONE is added to the column.

Testing (as compared to the example in issue 301):

salloc -N 1 -C gpu -A desi_g --gpus-per-node=4 -t 04:00:00 -q interactive

srun -n 4 --gpu-bind=map_gpu:3,2,1,0 --cpu-bind=cores rrdesi_mpi --gpu -n 100 \
  -i $CFS/desi/spectro/redux/iron/tiles/cumulative/80605/20210205/coadd-6-80605-thru20210205.fits \
  --model $SCRATCH/redrock/rrmodel-test.fits \
  -o $SCRATCH/redrock/redrock-test.fits

Proceeds without any warning...

import fitsio
zcat = fitsio.read('$SCRATCH/redrock/redrock-test.fits', 'REDSHIFTS')
set(zcat['FITMETHOD'])

Out[]: {'NONE', 'PCA'}

@coveralls
Copy link

coveralls commented Apr 29, 2024

Coverage Status

coverage: 38.825% (-0.2%) from 39.033%
when pulling 55d9d61 on ADM-fix-none
into ae069fa on main.

@sbailey sbailey merged commit c15deae into main Apr 29, 2024
10 checks passed
@sbailey sbailey deleted the ADM-fix-none branch April 29, 2024 20:08
@sbailey sbailey mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants