Velodiff, take 2 #317
Merged
Velodiff, take 2 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shoot; mis-communication; looks like @abrodze made another change on velodiff while I was making this. Will go chat in person, apologies for the github noise... |
|
Testing the most recent commit on dark time from healpix 128, 4511, 8975, 9020, and 20410 yields the following zwarn changes:
I am happy to sign off on this PR. |
akremin
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR superseded PR #315 from @abrodze with description "changes to address issues with max_velo_diff variable explained in #312. Seems to work as intended, but it is still in test mode." This has the same changes, but has a cleaner difference history since I messed up her previous branch.