-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a model of twilight sky brightness #84
base: main
Are you sure you want to change the base?
Conversation
Update on the two issues mentioned earlier:
Three new plots to document the new model (which are now in the docs, along with instructions to reproduce them): |
You'll want to bring in the latest changes from master to get tests to pass. |
@dkirkby It would be very helpful to have this updated sky model implemented to carry out some bright-time redshift success tests, even if there's still work to be done. Can you provide any updates on when we might be able to merge this? Thanks! |
Any chance of getting these changes into the 18.12 software release? |
@dkirkby, this PR is now about 3 years old. Should we continue to keep this open? |
We now have a functional twilight model that can be used together with the scattered moon model for more realistic bright-time simulations. The two main questions I would like to follow up on eventually are:
However, I think the general features of this model are a big improvement over nothing so should be merged soon unless anyone spots obvious problems.
This PR also removes the (now obsolete)
sky-conditions
config parameter, which was originally to support using the gray/bright spectra in desimodel but is now redundant with the more flexible moon and twilight models.