Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup specsim to simulate eBOSS spectrograph #87

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

belaa
Copy link

@belaa belaa commented Jun 5, 2018

This PR includes a new configuration file specsim/data/config/eboss.yaml and additional data needed to simulate the eBOSS instrument in specsim/data/sdss. There is also a notebook docs/nb/eBOSSConfigData.ipynb that shows how this data was generated.

@dkirkby
Copy link
Member

dkirkby commented Jul 30, 2018

I don't think anything in desi.yaml should change with this PR.

Are the files in data/sdss/ with DESI-0347 in the name necessary?

Please merge in the latest updates to master: hopefully that will help with the travis tests.

specsim/data/config/desi.yaml Outdated Show resolved Hide resolved
@belaa
Copy link
Author

belaa commented Sep 20, 2018

@dkirkby The sdss/throughput/DESI-0347_random_offset_*.fits files don't seem necessary and I've removed them. I had originally included the other two DESI-0347 files since they were the default files used to calculate blur and offset in the desi config.

@weaverba137
Copy link
Member

@belaa, @dkirkby, what is the status of this PR and of #100? The eBOSS survey is technically complete....

@dkirkby
Copy link
Member

dkirkby commented Aug 6, 2020

@weaverba137 This is still an active PR and will be merged soon.

@weaverba137
Copy link
Member

Thank you, we'll leave it alone. You'll definitely need to rebase though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants