Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 2.39.3 #445

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Bump to 2.39.3 #445

merged 3 commits into from
Apr 26, 2023

Conversation

tidy-dev
Copy link
Contributor

@tidy-dev tidy-dev commented Apr 25, 2023

Bumps Git to 2.39.3 and Git for Windows to v2.39.3.windows.1

EDIT:

@theofficialgman
Copy link
Contributor

@tidy-dev I'll look into why it broke
I actually tested on focal before merging the PR and it went fine

@tidy-dev tidy-dev requested review from sergiou87 and niik April 25, 2023 19:03
@tidy-dev
Copy link
Contributor Author

@theofficialgman Yeah. It looks like it was merged March 15th and the support for ubuntu-18.04 dropped on April 3rd. Thus, it probably did work then.

@tidy-dev tidy-dev enabled auto-merge April 25, 2023 20:19
@theofficialgman
Copy link
Contributor

theofficialgman commented Apr 25, 2023

Please do not merge this PR. It has been superseded by #446

@niik
Copy link
Member

niik commented Apr 26, 2023

Please do not merge this PR. It has been superseded by #446

The release has already been made and it had to get done yesterday in order for GitHub Desktop to be able to ship today. This release contains fixes for several Git security vulnerabilities and is high priority. Please update your PR once this is merged and we'll take a look at it separately.

@niik niik disabled auto-merge April 26, 2023 06:31
@niik niik merged commit 7127f4d into master Apr 26, 2023
@niik niik deleted the Bump-to-2.29.3 branch April 26, 2023 06:32
@theofficialgman
Copy link
Contributor

I would have prefered that the PR was not merged since commit history is now worse for now reason (there is no issue with a tag existing outside of the master branch which was the case)

Regardless, I have updated the PR to revert these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants