some SSL certificate bundle tweaks #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I have just made some changes to be able to run tests with external Git too. Just in case if you are interested, I can make some contributions: master...kittaakos:GH-87 |
|
@kittaakos oh that's cool - I'd love to get those external tests in too if you're interested in building upon this work! |
kittaakos
reviewed
Sep 5, 2017
| @@ -1,5 +1,11 @@ | |||
| import * as path from 'path' | |||
|
|
|||
| function resolveEmbeddedGitDir(): string { | |||
| const s = path.sep; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
Fixes #86
cc @kittaakos