Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git 2.26.2-1 #404

Closed
wants to merge 10 commits into from
Closed

git 2.26.2-1 #404

wants to merge 10 commits into from

Conversation

rafeca
Copy link
Contributor

@rafeca rafeca commented Jun 23, 2020

This PR is based on #399. Includes the same changes as #399 plus all the changes that have happened in master since #399 was created.

@rafeca rafeca requested review from niik and outofambit June 23, 2020 14:39
@rafeca rafeca changed the title Release/git 2.26.2 1 git 2.26.2-1 Jun 23, 2020
This was referenced Jun 23, 2020
Closed
Closed
@rafeca
Copy link
Contributor Author

rafeca commented Jun 23, 2020

I've already created a v1.91.2 tag based on 1dda875 (was created as part of the npm version patch).

I'm going to wait for an approval before running npm publish on that tag.

niik
niik approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@niik niik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to wait for an approval before running npm publish on that tag.

You've got it, but please wait for CI to finish before publishing as well

@rafeca rafeca mentioned this pull request Jun 24, 2020
Merged
@rafeca
Copy link
Contributor Author

rafeca commented Jun 24, 2020

Superseded by #405

@rafeca rafeca closed this Jun 24, 2020
@rafeca rafeca deleted the release/git-2.26.2-1 branch June 24, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niik niik niik approved these changes

@outofambit outofambit Awaiting requested review from outofambit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafeca @niik @outofambit