Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] Allow aborting exec, remove execTask #590

Merged
merged 23 commits into from
Oct 21, 2024
Merged

[Breaking] Allow aborting exec, remove execTask #590

merged 23 commits into from
Oct 21, 2024

Commits on Oct 17, 2024

  1. Remove execTask in favor of signal/killSignal support

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9f4bd12 View commit details
    Browse the repository at this point in the history

  2. Introduce execerror

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e75c6b8 View commit details
    Browse the repository at this point in the history

  3. Get rid of GitTask

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b86f95c View commit details
    Browse the repository at this point in the history

  4. maxBuffer error message is good enough as it is

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2dcc79e View commit details
    Browse the repository at this point in the history

  5. 🎨 cleanup

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    020f974 View commit details
    Browse the repository at this point in the history

  6. Remove deprecated exports

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    91cf40c View commit details
    Browse the repository at this point in the history

  7. Don't need this any more

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    69284a4 View commit details
    Browse the repository at this point in the history

  8. Use the right message and code

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    00c804f View commit details
    Browse the repository at this point in the history

  9. This is handled below already

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f578907 View commit details
    Browse the repository at this point in the history

  10. Update tests

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    12441dc View commit details
    Browse the repository at this point in the history

  11. 🎨 cleanup

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7822a41 View commit details
    Browse the repository at this point in the history

  12. Align with ExecFileException

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5bc9ec5 View commit details
    Browse the repository at this point in the history

  13. 🎨 cleanup

    @niik
    niik committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    808a682 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. [Breaking] Remove RepositoryDoesNotExist and GitNotFound errors 

    Instead of synchronously stat'ing the path on ENOENT when it's possible that the caller doesn't care we'll leave it up to callers to choose whether to try to detect why the exec failed.

Note that the pathExist approach was subject to race conditions and that there's no guarantee you'd ever be able to figure out exactly why the call failed
    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6352c41 View commit details
    Browse the repository at this point in the history

  2. Forward the most important properties from the causing error (if any)

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    74aaf13 View commit details
    Browse the repository at this point in the history

  3. Turns out we don't need the sad hack?!

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c100345 View commit details
    Browse the repository at this point in the history

  4. 🎨 cleanup

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2d1f695 View commit details
    Browse the repository at this point in the history

  5. Get rid of ErrorWithCode

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    25c5fa3 View commit details
    Browse the repository at this point in the history

  6. Export ExecError

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f2c237c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into abortable-exec

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bf9119d View commit details
    Browse the repository at this point in the history

  8. Default to utf8

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5243a5b View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into abortable-exec

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1f02a12 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into abortable-exec

    @niik
    niik committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c1cfd3d View commit details
    Browse the repository at this point in the history