Merge branch 'master' of github.com:desmos-labs/desmos into riccardom…

…/prepare-v4.1.0

.golangci.yml

@@ -1,5 +1,6 @@
 run:
  tests: false
+ timeout: 5m
  skip-dirs:
  - pkg
 
@@ -10,32 +11,25 @@ linters:
  - deadcode
  - depguard
  - dogsled
- # - errcheck
+ - exportloopref
  - goconst
  - gocritic
  - gofmt
  - goimports
- - golint
  - gosec
  - gosimple
  - govet
  - ineffassign
- - interfacer
- - maligned
  - misspell
  - nakedret
- - prealloc
- - scopelint
+ - nolintlint
  - staticcheck
  - structcheck
  - stylecheck
  - typecheck
  - unconvert
- - unused
  - unparam
- - misspell
- # - wsl
- - nolintlint
+ - unused
 
 issues:
  exclude-rules:
@@ -51,6 +45,13 @@ issues:
  - text: "ST1003:"
  linters:
  - stylecheck
+
+ # FIXME: Disabled until golangci-lint updates stylecheck with this fix:
+ # https://github.com/dominikh/go-tools/issues/389
+ - text: "ST1016:"
+ linters:
+ - stylecheck
+
  # TODO: Remove these when we are ready to drop support for Legacy Amino
  - text: "SA1019: codec.LegacyAmino is deprecated"
  linters:
@@ -62,10 +63,10 @@ issues:
  linters:
  - staticcheck
 
- # TODO: Remove this once we have implemented expected_keepers for all the modules
- - text: "`bk` can be `github.com/cosmos/cosmos-sdk/x/simulation.BankKeeper`"
+ - path: "migrations"
+  text: "SA1019:"
  linters:
- - interfacer
+ - staticcheck
  max-issues-per-linter: 10000
  max-same-issues: 10000
 

Makefile

@@ -280,12 +280,16 @@ benchmark:
 ###############################################################################
 ### Linting ###
 ###############################################################################
+golangci_lint_cmd=github.com/golangci/golangci-lint/cmd/golangci-lint
 
 lint:
- golangci-lint run --out-format=tab --timeout=10m
+ @echo "--> Running linter"
+ @go run $(golangci_lint_cmd) run --timeout=10m
 
 lint-fix:
- golangci-lint run --fix --out-format=tab --issues-exit-code=0 --timeout=10m
+ @echo "--> Running linter"
+ @go run $(golangci_lint_cmd) run --fix --out-format=tab --issues-exit-code=0
+
 .PHONY: lint lint-fix
 
 format:

app/desmos/cmd/testnet.go

@@ -392,10 +392,9 @@ func calculateIP(ip string, i int) (string, error) {
 }
 
 func writeFile(name string, dir string, contents []byte) error {
- writePath := filepath.Join(dir)
- file := filepath.Join(writePath, name)
+ file := filepath.Join(dir, name)
 
- err := tmos.EnsureDir(writePath, 0755)
+ err := tmos.EnsureDir(dir, 0755)
  if err != nil {
  return err
  }

go.mod

@@ -13,6 +13,7 @@ require (
  github.com/ghodss/yaml v1.0.0
  github.com/gogo/protobuf v1.3.3
  github.com/golang/protobuf v1.5.2
+ github.com/golangci/golangci-lint v1.46.2
  github.com/gorilla/mux v1.8.0
  github.com/grpc-ecosystem/grpc-gateway v1.16.0
  github.com/manifoldco/promptui v0.9.0
@@ -33,17 +34,36 @@ require (
 )
 
 require (
+ 4d63.com/gochecknoglobals v0.1.0 // indirect
  filippo.io/edwards25519 v1.0.0-beta.2 // indirect
  github.com/99designs/keyring v1.1.6 // indirect
+ github.com/Antonboom/errname v0.1.6 // indirect
+ github.com/Antonboom/nilnil v0.1.1 // indirect
+ github.com/BurntSushi/toml v1.1.0 // indirect
  github.com/ChainSafe/go-schnorrkel v0.0.0-20200405005733-88cbf1b4c40d // indirect
  github.com/CosmWasm/wasmvm v1.0.0 // indirect
  github.com/DataDog/zstd v1.4.5 // indirect
+ github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24 // indirect
+ github.com/GaijinEntertainment/go-exhaustruct/v2 v2.1.0 // indirect
+ github.com/Masterminds/semver v1.5.0 // indirect
+ github.com/OpenPeeDeeP/depguard v1.1.0 // indirect
  github.com/Workiva/go-datastructures v1.0.53 // indirect
+ github.com/alexkohler/prealloc v1.0.0 // indirect
+ github.com/ashanbrown/forbidigo v1.3.0 // indirect
+ github.com/ashanbrown/makezero v1.1.1 // indirect
  github.com/beorn7/perks v1.0.1 // indirect
  github.com/bgentry/speakeasy v0.1.0 // indirect
+ github.com/bkielbasa/cyclop v1.2.0 // indirect
+ github.com/blizzy78/varnamelen v0.8.0 // indirect
+ github.com/bombsimon/wsl/v3 v3.3.0 // indirect
+ github.com/breml/bidichk v0.2.3 // indirect
+ github.com/breml/errchkjson v0.3.0 // indirect
  github.com/btcsuite/btcd/btcec/v2 v2.2.0 // indirect
+ github.com/butuzov/ireturn v0.1.1 // indirect
  github.com/cespare/xxhash v1.1.0 // indirect
  github.com/cespare/xxhash/v2 v2.1.2 // indirect
+ github.com/charithe/durationcheck v0.0.9 // indirect
+ github.com/chavacava/garif v0.0.0-20220316182200-5cad0b5181d4 // indirect
  github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e // indirect
  github.com/coinbase/rosetta-sdk-go v0.7.0 // indirect
  github.com/confio/ics23/go v0.7.0 // indirect
@@ -52,79 +72,184 @@ require (
  github.com/cosmos/iavl v0.17.3 // indirect
  github.com/cosmos/ledger-cosmos-go v0.11.1 // indirect
  github.com/cosmos/ledger-go v0.9.2 // indirect
+ github.com/daixiang0/gci v0.3.3 // indirect
  github.com/danieljoos/wincred v1.0.2 // indirect
  github.com/davecgh/go-spew v1.1.1 // indirect
  github.com/decred/dcrd/dcrec/secp256k1/v4 v4.0.1 // indirect
+ github.com/denis-tingaikin/go-header v0.4.3 // indirect
  github.com/desertbit/timer v0.0.0-20180107155436-c41aec40b27f // indirect
  github.com/dgraph-io/badger/v2 v2.2007.2 // indirect
  github.com/dgraph-io/ristretto v0.0.3 // indirect
  github.com/dgryski/go-farm v0.0.0-20200201041132-a6ae2369ad13 // indirect
  github.com/dustin/go-humanize v1.0.0 // indirect
  github.com/dvsekhvalnov/jose2go v0.0.0-20200901110807-248326c1351b // indirect
+ github.com/esimonov/ifshort v1.0.4 // indirect
+ github.com/ettle/strcase v0.1.1 // indirect
+ github.com/fatih/color v1.13.0 // indirect
+ github.com/fatih/structtag v1.2.0 // indirect
  github.com/felixge/httpsnoop v1.0.1 // indirect
- github.com/fsnotify/fsnotify v1.5.1 // indirect
+ github.com/firefart/nonamedreturns v1.0.1 // indirect
+ github.com/fsnotify/fsnotify v1.5.4 // indirect
+ github.com/fzipp/gocyclo v0.5.1 // indirect
+ github.com/go-critic/go-critic v0.6.3 // indirect
  github.com/go-kit/kit v0.12.0 // indirect
  github.com/go-kit/log v0.2.0 // indirect
  github.com/go-logfmt/logfmt v0.5.1 // indirect
+ github.com/go-toolsmith/astcast v1.0.0 // indirect
+ github.com/go-toolsmith/astcopy v1.0.0 // indirect
+ github.com/go-toolsmith/astequal v1.0.1 // indirect
+ github.com/go-toolsmith/astfmt v1.0.0 // indirect
+ github.com/go-toolsmith/astp v1.0.0 // indirect
+ github.com/go-toolsmith/strparse v1.0.0 // indirect
+ github.com/go-toolsmith/typep v1.0.2 // indirect
+ github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b // indirect
+ github.com/gobwas/glob v0.2.3 // indirect
  github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect
+ github.com/gofrs/flock v0.8.1 // indirect
  github.com/gogo/gateway v1.1.0 // indirect
  github.com/golang/snappy v0.0.4 // indirect
+ github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2 // indirect
+ github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a // indirect
+ github.com/golangci/go-misc v0.0.0-20220329215616-d24fe342adfe // indirect
+ github.com/golangci/gofmt v0.0.0-20190930125516-244bba706f1a // indirect
+ github.com/golangci/lint-1 v0.0.0-20191013205115-297bf364a8e0 // indirect
+ github.com/golangci/maligned v0.0.0-20180506175553-b1d89398deca // indirect
+ github.com/golangci/misspell v0.3.5 // indirect
+ github.com/golangci/revgrep v0.0.0-20210930125155-c22e5001d4f2 // indirect
+ github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4 // indirect
  github.com/google/btree v1.0.0 // indirect
+ github.com/google/go-cmp v0.5.7 // indirect
  github.com/google/gofuzz v1.2.0 // indirect
  github.com/google/orderedcode v0.0.1 // indirect
+ github.com/gordonklaus/ineffassign v0.0.0-20210914165742-4cc7213b9bc8 // indirect
  github.com/gorilla/handlers v1.5.1 // indirect
  github.com/gorilla/websocket v1.5.0 // indirect
+ github.com/gostaticanalysis/analysisutil v0.7.1 // indirect
+ github.com/gostaticanalysis/comment v1.4.2 // indirect
+ github.com/gostaticanalysis/forcetypeassert v0.1.0 // indirect
+ github.com/gostaticanalysis/nilerr v0.1.1 // indirect
  github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect
  github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect
  github.com/gtank/merlin v0.1.1 // indirect
  github.com/gtank/ristretto255 v0.1.2 // indirect
+ github.com/hashicorp/errwrap v1.0.0 // indirect
  github.com/hashicorp/go-immutable-radix v1.3.1 // indirect
+ github.com/hashicorp/go-multierror v1.1.1 // indirect
+ github.com/hashicorp/go-version v1.4.0 // indirect
  github.com/hashicorp/golang-lru v0.5.5-0.20210104140557-80c98217689d // indirect
  github.com/hashicorp/hcl v1.0.0 // indirect
  github.com/hdevalence/ed25519consensus v0.0.0-20210204194344-59a8610d2b87 // indirect
+ github.com/hexops/gotextdiff v1.0.3 // indirect
  github.com/improbable-eng/grpc-web v0.14.1 // indirect
  github.com/inconshreveable/mousetrap v1.0.0 // indirect
+ github.com/jgautheron/goconst v1.5.1 // indirect
+ github.com/jingyugao/rowserrcheck v1.1.1 // indirect
+ github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af // indirect
  github.com/jmhodges/levigo v1.0.0 // indirect
+ github.com/julz/importas v0.1.0 // indirect
  github.com/keybase/go-keychain v0.0.0-20190712205309-48d3d31d256d // indirect
+ github.com/kisielk/errcheck v1.6.0 // indirect
+ github.com/kisielk/gotool v1.0.0 // indirect
  github.com/klauspost/compress v1.13.6 // indirect
+ github.com/kulti/thelper v0.6.2 // indirect
+ github.com/kunwardeep/paralleltest v1.0.3 // indirect
+ github.com/kyoh86/exportloopref v0.1.8 // indirect
+ github.com/ldez/gomoddirectives v0.2.3 // indirect
+ github.com/ldez/tagliatelle v0.3.1 // indirect
+ github.com/leonklingele/grouper v1.1.0 // indirect
  github.com/lib/pq v1.10.4 // indirect
  github.com/libp2p/go-buffer-pool v0.0.2 // indirect
+ github.com/lufeee/execinquery v1.2.1 // indirect
  github.com/magiconair/properties v1.8.6 // indirect
+ github.com/maratori/testpackage v1.0.1 // indirect
+ github.com/matoous/godox v0.0.0-20210227103229-6504466cf951 // indirect
+ github.com/mattn/go-colorable v0.1.12 // indirect
  github.com/mattn/go-isatty v0.0.14 // indirect
+ github.com/mattn/go-runewidth v0.0.9 // indirect
  github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
+ github.com/mbilski/exhaustivestruct v1.2.0 // indirect
+ github.com/mgechev/revive v1.2.1 // indirect
  github.com/mimoo/StrobeGo v0.0.0-20181016162300-f8f6d4d2b643 // indirect
  github.com/minio/highwayhash v1.0.2 // indirect
- github.com/mitchellh/mapstructure v1.4.3 // indirect
+ github.com/mitchellh/go-homedir v1.1.0 // indirect
+ github.com/mitchellh/mapstructure v1.5.0 // indirect
+ github.com/moricho/tparallel v0.2.1 // indirect
  github.com/mtibben/percent v0.2.1 // indirect
- github.com/pelletier/go-toml v1.9.4 // indirect
- github.com/pelletier/go-toml/v2 v2.0.0-beta.8 // indirect
+ github.com/nakabonne/nestif v0.3.1 // indirect
+ github.com/nbutton23/zxcvbn-go v0.0.0-20210217022336-fa2cb2858354 // indirect
+ github.com/nishanths/exhaustive v0.7.11 // indirect
+ github.com/nishanths/predeclared v0.2.2 // indirect
+ github.com/olekukonko/tablewriter v0.0.5 // indirect
+ github.com/pelletier/go-toml v1.9.5 // indirect
+ github.com/pelletier/go-toml/v2 v2.0.0 // indirect
  github.com/petermattis/goid v0.0.0-20180202154549-b0b1615b78e5 // indirect
+ github.com/phayes/checkstyle v0.0.0-20170904204023-bfd46e6a821d // indirect
  github.com/pkg/errors v0.9.1 // indirect
  github.com/pmezard/go-difflib v1.0.0 // indirect
+ github.com/polyfloyd/go-errorlint v1.0.0 // indirect
  github.com/prometheus/client_model v0.2.0 // indirect
  github.com/prometheus/common v0.32.1 // indirect
  github.com/prometheus/procfs v0.7.3 // indirect
+ github.com/quasilyte/go-ruleguard v0.3.16-0.20220213074421-6aa060fab41a // indirect
+ github.com/quasilyte/gogrep v0.0.0-20220120141003-628d8b3623b5 // indirect
+ github.com/quasilyte/regex/syntax v0.0.0-20200407221936-30656e2c4a95 // indirect
+ github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect
  github.com/rcrowley/go-metrics v0.0.0-20200313005456-10cdbea86bc0 // indirect
  github.com/rs/cors v1.8.2 // indirect
  github.com/rs/zerolog v1.26.0 // indirect
+ github.com/ryancurrah/gomodguard v1.2.3 // indirect
+ github.com/ryanrolds/sqlclosecheck v0.3.0 // indirect
+ github.com/sanposhiho/wastedassign/v2 v2.0.6 // indirect
  github.com/sasha-s/go-deadlock v0.2.1-0.20190427202633-1595213edefa // indirect
+ github.com/securego/gosec/v2 v2.11.0 // indirect
+ github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c // indirect
+ github.com/sirupsen/logrus v1.8.1 // indirect
+ github.com/sivchari/containedctx v1.0.2 // indirect
+ github.com/sivchari/tenv v1.5.0 // indirect
+ github.com/sonatard/noctx v0.0.1 // indirect
+ github.com/sourcegraph/go-diff v0.6.1 // indirect
  github.com/spf13/afero v1.8.2 // indirect
  github.com/spf13/jwalterweatherman v1.1.0 // indirect
  github.com/spf13/viper v1.11.0 // indirect
+ github.com/ssgreg/nlreturn/v2 v2.2.1 // indirect
+ github.com/stbenjam/no-sprintf-host-port v0.1.1 // indirect
+ github.com/stretchr/objx v0.4.0 // indirect
  github.com/subosito/gotenv v1.2.0 // indirect
+ github.com/sylvia7788/contextcheck v1.0.4 // indirect
  github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 // indirect
+ github.com/tdakkota/asciicheck v0.1.1 // indirect
  github.com/tendermint/btcd v0.1.1 // indirect
  github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15 // indirect
  github.com/tendermint/go-amino v0.16.0 // indirect
+ github.com/tetafro/godot v1.4.11 // indirect
+ github.com/timakin/bodyclose v0.0.0-20210704033933-f49887972144 // indirect
+ github.com/tomarrell/wrapcheck/v2 v2.6.1 // indirect
+ github.com/tommy-muehle/go-mnd/v2 v2.5.0 // indirect
+ github.com/ultraware/funlen v0.0.3 // indirect
+ github.com/ultraware/whitespace v0.0.5 // indirect
+ github.com/uudashr/gocognit v1.0.5 // indirect
+ github.com/yagipy/maintidx v1.0.0 // indirect
+ github.com/yeya24/promlinter v0.2.0 // indirect
  github.com/zondax/hid v0.9.0 // indirect
+ gitlab.com/bosi/decorder v0.2.1 // indirect
  go.etcd.io/bbolt v1.3.6 // indirect
  golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 // indirect
+ golang.org/x/exp/typeparams v0.0.0-20220218215828-6cf2b201936e // indirect
+ golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 // indirect
  golang.org/x/net v0.0.0-20220412020605-290c469a71a5 // indirect
- golang.org/x/sys v0.0.0-20220412211240-33da011f77ad // indirect
+ golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
+ golang.org/x/sys v0.0.0-20220422013727-9388b58f7150 // indirect
  golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect
  golang.org/x/text v0.3.7 // indirect
+ golang.org/x/tools v0.1.11-0.20220316014157-77aa08bb151a // indirect
+ golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f // indirect
  gopkg.in/ini.v1 v1.66.4 // indirect
  gopkg.in/yaml.v3 v3.0.1 // indirect
+ honnef.co/go/tools v0.3.1 // indirect
+ mvdan.cc/gofumpt v0.3.1 // indirect
+ mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed // indirect
+ mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b // indirect
+ mvdan.cc/unparam v0.0.0-20211214103731-d0ef000c54e5 // indirect
  nhooyr.io/websocket v1.8.6 // indirect
 )