fix: add missing subspaces authz migration

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

proto/desmos/subspaces/v2/authz/authz.proto

@@ -0,0 +1,21 @@
+syntax = "proto3";
+package desmos.subspaces.v2.authz;
+
+import "gogoproto/gogo.proto";
+import "cosmos_proto/cosmos.proto";
+import "cosmos/base/v1beta1/coin.proto";
+
+option go_package = "github.com/desmos-labs/desmos/v4/x/subspaces/legacy/v2";
+
+// GenericSubspaceAuthorization defines an authorization to perform any
+// operation only inside a specific subspace.
+message GenericSubspaceAuthorization {
+ option (cosmos_proto.implements_interface) = "Authorization";
+
+ // Ids of the subspaces inside which to grant the permission
+ repeated uint64 subspaces_ids = 1 [ (gogoproto.customname) = "SubspacesIDs" ];
+
+ // Msg, identified by it's type URL, to grant unrestricted permissions to
+ // execute within the subspace
+ string msg = 2;
+}

x/subspaces/keeper/migrations.go

@@ -3,9 +3,9 @@ package keeper
 import (
  sdk "github.com/cosmos/cosmos-sdk/types"
 
- v3 "github.com/desmos-labs/desmos/v4/x/subspaces/legacy/v3"
-
  v2 "github.com/desmos-labs/desmos/v4/x/subspaces/legacy/v2"
+ v3 "github.com/desmos-labs/desmos/v4/x/subspaces/legacy/v3"
+ v4 "github.com/desmos-labs/desmos/v4/x/subspaces/legacy/v4"
 )
 
 // DONTCOVER
@@ -31,3 +31,8 @@ func (m Migrator) Migrate1to2(ctx sdk.Context) error {
 func (m Migrator) Migrate2to3(ctx sdk.Context) error {
  return v3.MigrateStore(ctx, m.keeper.storeKey, m.keeper.cdc)
 }
+
+// Migrate3to4 migrates from version 3 to 4.
+func (m Migrator) Migrate3to4(ctx sdk.Context) error {
+ return v4.MigrateStore(ctx, m.keeper.storeKey, m.keeper.cdc)
+}

x/subspaces/legacy/v2/authz.go

@@ -0,0 +1,65 @@
+package v2
+
+// DONTCOVER
+
+import (
+ sdk "github.com/cosmos/cosmos-sdk/types"
+ sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
+ "github.com/cosmos/cosmos-sdk/x/authz"
+
+ "github.com/desmos-labs/desmos/v4/x/subspaces/types"
+)
+
+// TODO: Revisit this once we have proper gas fee framework.
+// Tracking issues https://github.com/cosmos/cosmos-sdk/issues/9054, https://github.com/cosmos/cosmos-sdk/discussions/9072
+const gasCostPerIteration = uint64(10)
+
+var (
+ _ authz.Authorization = &GenericSubspaceAuthorization{}
+)
+
+// NewGenericSubspaceAuthorization creates a new GenericSubspaceAuthorization object.
+func NewGenericSubspaceAuthorization(subspacesIDs []uint64, msgTypeURL string) *GenericSubspaceAuthorization {
+ return &GenericSubspaceAuthorization{
+ SubspacesIDs: subspacesIDs,
+ Msg: msgTypeURL,
+ }
+}
+
+// MsgTypeURL implements Authorization.MsgTypeURL.
+func (a GenericSubspaceAuthorization) MsgTypeURL() string {
+ return a.Msg
+}
+
+// Accept implements Authorization.Accept.
+func (a GenericSubspaceAuthorization) Accept(ctx sdk.Context, msg sdk.Msg) (authz.AcceptResponse, error) {
+ switch msg := msg.(type) {
+
+ case types.SubspaceMsg:
+ for _, subspaceID := range a.SubspacesIDs {
+ ctx.GasMeter().ConsumeGas(gasCostPerIteration, "generic subspace authorization")
+ if subspaceID == msg.GetSubspaceID() {
+ return authz.AcceptResponse{Accept: true}, nil
+ }
+ }
+ return authz.AcceptResponse{Accept: false}, nil
+
+ default:
+ return authz.AcceptResponse{}, sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "unknown msg type")
+ }
+}
+
+// ValidateBasic implements Authorization.ValidateBasic.
+func (a GenericSubspaceAuthorization) ValidateBasic() error {
+ if a.SubspacesIDs == nil {
+ return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "at least one subspace id is required")
+ }
+
+ for _, subspaceID := range a.SubspacesIDs {
+ if subspaceID == 0 {
+ return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "invalid subspace id")
+ }
+ }
+
+ return nil
+}