-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile changes #193
Comments
Even if I feel comfortable with the current one I understood your concerns about it.
|
I agree the I agree with the points @RiccardoM suggested in the proposal. And I also agree @bragaz 's concerns which we better use another term instead of just To also serve the we may record the date of the profile creation date. At the end it will not be The What term should we use for the |
Something like |
I'm ok with @bragaz's observation and renaming @kwunyeung's proposal about tracking the creation can be also achieved by using the I'll take care of implementing these changes. |
Feature description
Inside the
x/profile
module we currently use the following structure to store the data of a user:After a couple of users have created their profile, I've noticed some things particular:
Name
andSurname
are used incorrectly, often filled with fake data in any case;Moniker
is the one that truly identifies a user, and most users have set monikers to be their usernames.I think that we should probably revisit some of the functionalities and checks that we currently have in order to give this object a proper meaning.
Implementation proposal
What I suggest to do is the following.
Remove the
Name
andSurname
fields.These data will be collected in any case in a middle layer managed by dApps if they want to have it. No sane user will publish his/her name on a blockchain project in any case.
Rename the
Moniker
to beTag
or something similar (proposals accepted).This will be used to properly tag (
@
) people inside posts and/or photo.Add a validation process to the new
Tag
field.I think we should probably take what other social networks (like Instagram, Twitter, etc.) do to make sure tags are valid. This means no white spaces and a short max length allowed (further researches should be done on this point).
Please @kwunyeung and @bragaz let me know what do you think about this.
The text was updated successfully, but these errors were encountered: