Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile changes #195

Merged
merged 16 commits into from
Jun 24, 2020
Merged

Profile changes #195

merged 16 commits into from
Jun 24, 2020

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jun 15, 2020 •
edited
Loading

Description

This PR implements the profile changes as described into the associated issue.
Closes #193.

Implementations checklist

  • Rename the original Moniker to DTag
  • Add a new optional Moniker to represent the user name
  • Add a validation to the DTag
  • Implement the creation time field

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM RiccardoM added kind/enhancement Enhance an already existing feature; no "New feature" to add x/profiles Module that allows to create and manage decentralized social profiles labels Jun 15, 2020
@RiccardoM RiccardoM added this to the v0.8.0 milestone Jun 15, 2020
@RiccardoM RiccardoM requested a review from leobragaz June 15, 2020 13:20
@RiccardoM RiccardoM removed the request for review from leobragaz June 16, 2020 05:28
@RiccardoM RiccardoM marked this pull request as draft June 16, 2020 05:29
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
cb23611 
…profile-changes
@RiccardoM
Docs & Bug fixes
106ba97 
- Fixed the documentation of the MsgSaveProfile
- Changed the JSON attribute of MsgSaveProfile from profile_cov to cover_picture and from profile_pic to profile_picture
- Fixed a bug inside the Equals method of pictures.go
@RiccardoM
Fixed the simulation tests to make them more realistic
4c0be6c
@RiccardoM
Fixed CLI tests
dede173
@RiccardoM
Added the creation date to the profile
0b0f480
@codecov
Copy link

codecov bot commented Jun 19, 2020 •
edited
Loading

Codecov Report

Merging #195 into master will decrease coverage by 0.18%.
The diff coverage is 88.78%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   83.44%   83.25%   -0.19%     
==========================================
  Files          71       73       +2     
  Lines        2633     2669      +36     
==========================================
+ Hits         2197     2222      +25     
- Misses        378      386       +8     
- Partials       58       61       +3

@RiccardoM RiccardoM requested a review from leobragaz June 19, 2020 07:48
@RiccardoM RiccardoM marked this pull request as ready for review June 19, 2020 11:06
leobragaz
leobragaz requested changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@leobragaz leobragaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is ok to me, you should only add a test to check if the ConvertProfiles function inside v0.8.0 migrate.go works properly (doing this should also fix the coverage loss).

@RiccardoM RiccardoM requested a review from leobragaz June 24, 2020 05:13
leobragaz
leobragaz approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to be merged!

@RiccardoM RiccardoM merged commit e934337 into master Jun 24, 2020
@RiccardoM RiccardoM deleted the riccardo/profile-changes branch June 24, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobragaz leobragaz leobragaz approved these changes

Assignees
No one assigned
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Profile changes
2 participants
@RiccardoM @leobragaz