-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs inside the DTag transferring process #296
Comments
I think I've understood why this txs error occurred. |
@RiccardoM I will add some more integration tests to a new PR that should solve this and #295 |
Bug description
During the completion of the Desmos Primer Phase 6 challenge that required them to perform a DTag transferring, the Discord user MikeSnowman75 told me they ran into a strange behavior that did not allow him to exchange the DTag properly.
Steps to reproduce
Reporting his words, here is what he did with an additional analyses from me.
He tried to transfer the dtag first in these 2 transactions:
As we can already see, there are two problems here:
The first transaction has an empty
dtag_to_trade
.This might say that the sending profile did not exist, or it didn't have the DTag set. This is a bug I've already reported inside MsgRequestDTagTransfer allows for empty DTag transfering #292.
The second message fails with error
profile of desmos1k7q92w7ku72ycutz6xqrx67v92yycff3emz88s doesn't exist
.This should not have happened. If a user wants a DTag of another user without having created a profile first, then a new profile for the receiving user should be created and the DTag transferring should continue properly.
After this, he tried with other two transactions:
First
Second
From them, we can see that:
the owner's DTag is different from the one to be exchanged
.Apparently, something here messed up because this one should not have failed here.
Also, they said that they tried performing another transaction. As you can see, this failed with error:
To be honest, I don't think this error should ever verify. If an Alice -> Bob transfer was made successfully, then once it concluded it should be removed allowing Alice to send Bob another DTag if she wants. I've reported this bug inside #295.
Expected behavior
The first transferring should have completed properly, as well as the second one.
The text was updated successfully, but these errors were encountered: