Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty dTag transfer fix #303

Merged
merged 6 commits into from
Oct 15, 2020
Merged

Empty dTag transfer fix #303

merged 6 commits into from
Oct 15, 2020

Conversation

leobragaz
Copy link
Contributor

Description

This PR fixes the possibility to request a transfer of an empty dTag.
This situation occurs when the dTag owner doesn't have a profile.
Closes #293 .

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@leobragaz leobragaz changed the title Empty Dtag transfer fix Empty dTag transfer fix Oct 14, 2020
@leobragaz leobragaz self-assigned this Oct 15, 2020
@leobragaz leobragaz added x/profiles Module that allows to create and manage decentralized social profiles kind/bug Something isn't working labels Oct 15, 2020
RiccardoM
RiccardoM reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes and then it should be good to go

CHANGELOG.md Outdated Show resolved Hide resolved
x/profiles/keeper/handler.go Outdated Show resolved Hide resolved
x/profiles/keeper/handler_test.go Outdated Show resolved Hide resolved
cli_test/cli_profile_test.go Outdated Show resolved Hide resolved
@RiccardoM RiccardoM merged commit 7d9747e into master Oct 15, 2020
@RiccardoM RiccardoM deleted the leonardo/empty-dtag-transfer-fix branch October 15, 2020 09:44
This was referenced Oct 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees

@leobragaz leobragaz

Labels
kind/bug Something isn't working x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MsgRequestDTagTransfer allows to ask for empty tag
2 participants
@leobragaz @RiccardoM