Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBC AnteHandler #714

Closed
RiccardoM opened this issue Jan 10, 2022 · 0 comments · Fixed by #717
Closed

Add IBC AnteHandler #714

RiccardoM opened this issue Jan 10, 2022 · 0 comments · Fixed by #717
Assignees
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add

Comments

@RiccardoM
Copy link
Contributor

We should add the IBC AnteHandler to our list of AnteHandlers, as done inside Gaia. This will ensure that relayers do not waste fees while performing multi-msg transactions containing packets that have already been relayed.

@RiccardoM RiccardoM added the kind/enhancement Enhance an already existing feature; no "New feature" to add label Jan 10, 2022
@RiccardoM RiccardoM self-assigned this Jan 10, 2022
@mergify mergify bot closed this as completed in #717 Jan 11, 2022
mergify bot pushed a commit that referenced this issue Jan 11, 2022
## Description
This PR adds the IBC `AnteHandler` to the list of ante handlers. Closes #714

Depends-On: #716

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html)
- [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant