Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register missing Wasm snapshotter extension #1069

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jan 17, 2023

Description

This PR adds the missing Wasm snapshotter extension inside the app.go file. This is an attempt to fix the bug that currently makes it impossible to properly use state sync due to CosmWasm contracts not being included inside the snapshots.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM RiccardoM requested a review from a team as a code owner January 17, 2023 16:56
@github-actions github-actions bot added x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module labels Jan 17, 2023
@RiccardoM RiccardoM changed the title feat: added Wasm snapshotter extension feat: register missing Wasm snapshotter extension Jan 17, 2023
@RiccardoM RiccardoM changed the title feat: register missing Wasm snapshotter extension fix: register missing Wasm snapshotter extension Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 80.41% // Head: 80.38% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (98f8174) compared to base (65b1da5).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1069      +/-   ##
==========================================
- Coverage   80.41%   80.38%   -0.03%     
==========================================
  Files         179      179              
  Lines       15604    15612       +8     
==========================================
+ Hits        12548    12550       +2     
- Misses       2511     2516       +5     
- Partials      545      546       +1     
Impacted Files Coverage Δ
x/subspaces/keeper/msg_server_treasury.go 95.89% <ø> (ø)
x/subspaces/legacy/v5/store.go 89.28% <ø> (ø)
app/app.go 87.34% <25.00%> (-0.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jan 18, 2023
@mergify mergify bot merged commit ac7d4c7 into master Jan 18, 2023
@mergify mergify bot deleted the riccardom/add-cosmwasm-snapshotter branch January 18, 2023 16:28
@RiccardoM
Copy link
Contributor Author

@mergify backport release/v4.7.x

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2023

backport release/v4.7.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 18, 2023
## Description

This PR adds the missing Wasm snapshotter extension inside the `app.go` file. This is an attempt to fix the bug that currently makes it impossible to properly use state sync due to CosmWasm contracts not being included inside the snapshots.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html)
- [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit ac7d4c7)

# Conflicts:
#	x/posts/testutil/expected_keepers_mocks.go
#	x/profiles/keeper/genesis_test.go
#	x/subspaces/client/cli/tx_treasury.go
#	x/subspaces/client/cli/tx_treasury_test.go
#	x/subspaces/keeper/msg_server_treasury.go
#	x/subspaces/legacy/v5/store.go
#	x/subspaces/legacy/v5/store_test.go
#	x/subspaces/types/models_test.go
#	x/subspaces/types/msgs_treasury_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants