build(deps): bump cosmos-sdk, cometbft cometbft-db #1124

RiccardoM · 2023-04-27T20:23:30Z

Description

This PR

bumps github.com/cosmos/cosmos-sdk to v0.47.2
bumps github.com/cometbft/cometbft to v0.37.1
bumps github.com/cometbft/cometbft-db to v0.8.0

Closes #1122
Closes #1123

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…ometbft-db

codecov · 2023-04-27T21:04:18Z

Codecov Report

Patch coverage: 71.26% and no project coverage change.

Comparison is base (6f56e96) 80.92% compared to head (adc75db) 80.93%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   80.92%   80.93%           
=======================================
  Files         194      198    +4     
  Lines       16901    16966   +65     
=======================================
+ Hits        13677    13731   +54     
- Misses       2629     2638    +9     
- Partials      595      597    +2

Impacted Files	Coverage Δ
x/profiles/module.go	`9.63% <0.00%> (-0.62%)`	⬇️
x/profiles/types/models_params.go	`90.06% <ø> (+6.11%)`	⬆️
x/profiles/types/models_params_legacy.go	`0.00% <0.00%> (ø)`
x/profiles/keeper/keeper_params.go	`75.00% <66.66%> (-25.00%)`	⬇️
x/profiles/legacy/v9/store.go	`76.92% <76.92%> (ø)`
app/app.go	`87.60% <100.00%> (ø)`
x/profiles/keeper/keeper.go	`91.60% <100.00%> (-0.13%)`	⬇️
x/profiles/keeper/msg_server_params.go	`100.00% <100.00%> (ø)`
x/profiles/types/codec.go	`100.00% <100.00%> (ø)`
x/profiles/types/msgs_params.go	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

RiccardoM · 2023-04-28T15:57:23Z

app/sim_test.go

+	// Create export folder
+	if config.ExportStatePath != "" {
+		err = os.MkdirAll(path.Dir(config.ExportStatePath), 0755)
+		require.NoError(t, err)
+	}
+	if config.ExportParamsPath != "" {
+		println(path.Dir(config.ExportParamsPath))
+		err = os.MkdirAll(path.Dir(config.ExportParamsPath), 0755)
+		require.NoError(t, err)
+	}


Since the CheckExportSimulation assumes the folders exist, we should make sure that they are present before being used. This should solve any possible problem about folders not existing

RiccardoM · 2023-04-28T15:58:10Z

app/sim_test.go

@@ -248,8 +258,6 @@ func TestAppImportExport(t *testing.T) {
 		{app.keys[poststypes.StoreKey], newApp.keys[poststypes.StoreKey], [][]byte{}},
 		{app.keys[reportstypes.StoreKey], newApp.keys[reportstypes.StoreKey], [][]byte{}},
 		{app.keys[reactionstypes.StoreKey], newApp.keys[reactionstypes.StoreKey], [][]byte{}},
-
-		{app.keys[wasm.StoreKey], newApp.keys[wasm.StoreKey], [][]byte{wasmtypes.TXCounterPrefix}},


If we don't remove this, some tests might fail with the following error:

compared 2 different key/value pairs between KVStoreKey{0xc001159ba0, wasm} and KVStoreKey{0xc00327f700, wasm} sim_test.go:275: Error Trace: /home/riccardo/Coding/Desmos/Desmos/app/sim_test.go:275 Error: Not equal: expected: 2 actual : 0 Test: TestAppImportExport Messages: store A => store B lastContractId => store A => store B =>

This is the case of a test that can be reproduced by running

cd app && go test . -run TestAppImportExport -Enabled=true -NumBlocks=50 -Genesis= -Verbose=true -Commit=true -Seed=981928 -Period=5 -ExportParamsPath /tmp/sim-logs-2838039267/sim_params-981928.json -ExportStatePath /tmp/sim-logs-2838039267/sim_state-981928.json -v -timeout 24h

It is because the x/wasm simulation does not generate the proper LastInstanceID for genesis state. I created an issue on wasmd repo. I think we can add it back after the issue is fixed.
CosmWasm/wasmd#1372

RiccardoM · 2023-04-28T15:58:40Z

x/posts/wasm/common_test.go

@@ -144,8 +143,6 @@ func (suite *TestSuite) SetupTest() {
 	suite.ctx = sdk.NewContext(ms, tmproto.Header{ChainID: "test-chain"}, false, log.NewNopLogger())
 	suite.cdc, suite.legacyAminoCdc = app.MakeCodecs()

-	paramsKeeper := paramskeeper.NewKeeper(suite.cdc, suite.legacyAminoCdc, keys[paramstypes.StoreKey], tKeys[paramstypes.TStoreKey])


This and all other paramsKeeper are no longer necessary, so we should remove them to make sure the linting passes

RiccardoM · 2023-04-28T15:59:15Z

Makefile

-test-race: ARGS=-race -tags='cgo ledger test_ledger_mock'
+test-unit: test_tags += cgo ledger test_ledger_mock norace
+test-unit-amino: test_tags += ledger test_ledger_mock test_amino norace
+test-ledger: test_tags += cgo ledger norace
+test-ledger-mock: test_tags += ledger test_ledger_mock norace
+test-race: test_tags += cgo ledger test_ledger_mock
+test-race: ARGS=-race


These changes are to make sure we use the same scheme as the Cosmos SDK so it's going to be easier for us to check any differences in the future

RiccardoM · 2023-04-28T15:59:39Z

.github/workflows/sims.yml

+concurrency:
+  group: ci-${{ github.ref }}-sims
+  cancel-in-progress: true


Taken from the Cosmos SDK repo, it aviods any concurrency between simulation tests. It should make sure we don't have multiple simulation tests running for the same PR/branch/commit at the same time

dadamu · 2023-05-02T05:17:58Z

go.mod

 	github.com/cosmos/cosmos-proto v1.0.0-beta.2
-	github.com/cosmos/cosmos-sdk v0.47.1
+	github.com/cosmos/cosmos-sdk v0.47.2


It is would be better to upgrade desmos-cosmos-sdk to 0.47.2 as well.

Thanks, updated it!

dadamu

LGTM

build(deps): bump cosmos/cosmos-sdk, cometbft/cometbft and cometbft/c…

5af82e6

…ometbft-db

RiccardoM requested a review from a team as a code owner April 27, 2023 20:23

RiccardoM requested review from manu0466 and dadamu April 27, 2023 20:24

fix: fixed tests

9ed28ab

manu0466 approved these changes Apr 28, 2023

View reviewed changes

RiccardoM added 2 commits April 28, 2023 10:06

build(ci): add concurrency data to simulation tests

00a07be

build: improve how tests are run

925b71a

github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD labels Apr 28, 2023

RiccardoM added 3 commits April 28, 2023 10:18

build: fix simulation test arguments not working

96a76e9

build(tests): add folder creation before data export

93c9e22

build(tests): remove wasm store prefix checks to avoid false negatives

a763db3

RiccardoM commented Apr 28, 2023

View reviewed changes

chore: added changeset

2ff3cd0

dadamu reviewed May 2, 2023

View reviewed changes

build(deps): bump desmos-labs/cosmos-sdk to v0.47.2-desmos

6a3f80a

RiccardoM requested a review from dadamu May 2, 2023 14:57

RiccardoM added the automerge Automatically merge PR once all prerequisites pass label May 2, 2023

build: upgrade Docker builders to use Go 1.19

adc75db

dadamu approved these changes May 2, 2023

View reviewed changes

mergify bot merged commit 71633dd into master May 2, 2023

mergify bot deleted the riccardom/upgrde-cosmos branch May 2, 2023 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(deps): bump cosmos-sdk, cometbft cometbft-db #1124

build(deps): bump cosmos-sdk, cometbft cometbft-db #1124

RiccardoM commented Apr 27, 2023 •

edited

Loading

codecov bot commented Apr 27, 2023 •

edited

Loading

RiccardoM Apr 28, 2023

RiccardoM Apr 28, 2023

dadamu May 2, 2023 •

edited

Loading

RiccardoM Apr 28, 2023

RiccardoM Apr 28, 2023

RiccardoM Apr 28, 2023

dadamu May 2, 2023

RiccardoM May 2, 2023

dadamu left a comment

build(deps): bump cosmos-sdk, cometbft cometbft-db #1124

build(deps): bump cosmos-sdk, cometbft cometbft-db #1124

Conversation

RiccardoM commented Apr 27, 2023 • edited Loading

Description

Author Checklist

Reviewers Checklist

codecov bot commented Apr 27, 2023 • edited Loading

Codecov Report

RiccardoM Apr 28, 2023

Choose a reason for hiding this comment

RiccardoM Apr 28, 2023

Choose a reason for hiding this comment

dadamu May 2, 2023 • edited Loading

Choose a reason for hiding this comment

RiccardoM Apr 28, 2023

Choose a reason for hiding this comment

RiccardoM Apr 28, 2023

Choose a reason for hiding this comment

RiccardoM Apr 28, 2023

Choose a reason for hiding this comment

dadamu May 2, 2023

Choose a reason for hiding this comment

RiccardoM May 2, 2023

Choose a reason for hiding this comment

dadamu left a comment

Choose a reason for hiding this comment

RiccardoM commented Apr 27, 2023 •

edited

Loading

codecov bot commented Apr 27, 2023 •

edited

Loading

dadamu May 2, 2023 •

edited

Loading