Reaction registration implementation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 17, 2020 11:28
…dency between reactions and post modules
…reactions-registration-limiting-impl � Conflicts: � x/posts/alias.go � x/posts/internal/types/genesis.go
…ted new msgRegisterReaction
leobragaz
added
x/posts
…ests, reaction test
added integration test + test helpers updated CHANGELOG.md TODO: - update migrate - update docs - implement unicode checks
- updated docs TODO: - update migrate - update PostReaction keeper's method
RiccardoM
suggested changes
Mar 26, 2020
| @@ -508,3 +522,54 @@ func TestDesmosCLIPostsReactions(t *testing.T) { | |||
|
|
|||
| f.Cleanup() | |||
| } | |||
|
|
|||
| func TestDesmosCLIRegisterReaction(t *testing.T) { | |||
There was a problem hiding this comment.
Can we have a test using an emoji as value such as 🎉 ?
…limiting-impl' into leonardo/reactions-registration-limiting-impl # Conflicts: # docs/types/reaction.md
…reactions-registration-limiting-impl � Conflicts: � CHANGELOG.md � cli_test/cli_posts_test.go
RiccardoM
suggested changes
Mar 26, 2020
golangcibot
reviewed
Mar 26, 2020
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
golangcibot
reviewed
Mar 26, 2020
golangcibot
reviewed
Mar 26, 2020
added 2 commits
March 26, 2020 16:28
…limiting-impl' into leonardo/reactions-registration-limiting-impl
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 82.56% 83.67% +1.11%
==========================================
Files 34 39 +5
Lines 1537 1654 +117
==========================================
+ Hits 1269 1384 +115
- Misses 238 239 +1
- Partials 30 31 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added the possibility to register a reaction to use it later when reacting to a post.
Closes #94
Checklist
CHANGELOG.mdfile.Files changedin the Github PR explorer.