Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error improvements #238

Merged
merged 12 commits into from
Jul 17, 2020
Merged

Error improvements #238

merged 12 commits into from
Jul 17, 2020

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jul 17, 2020

Description

This PR improves the errors usage (closes #237).

Closes #234

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM RiccardoM added this to the v0.10.0 milestone Jul 17, 2020
@RiccardoM RiccardoM requested a review from leobragaz July 17, 2020 08:47
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #238 into master will decrease coverage by 0.01%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   84.80%   84.79%   -0.02%     
==========================================
  Files          80       80              
  Lines        2896     2894       -2     
==========================================
- Hits         2456     2454       -2     
  Misses        377      377              
  Partials       63       63              
Impacted Files Coverage Δ
x/magpie/keeper/handler.go 81.25% <0.00%> (ø)
x/reports/keeper/handler.go 86.95% <0.00%> (ø)
x/posts/types/msgs/msgs.go 90.76% <71.42%> (+0.14%) ⬆️
x/magpie/types/msgs.go 96.00% <100.00%> (ø)
x/posts/types/msgs/msg_reactions.go 95.45% <100.00%> (ø)
x/posts/types/msgs/msgs_polls.go 100.00% <100.00%> (ø)
x/posts/types/msgs/msgs_post_reactions.go 100.00% <100.00%> (ø)
x/profiles/types/msgs.go 100.00% <100.00%> (ø)
x/reports/types/models/report.go 100.00% <100.00%> (ø)
x/reports/types/msgs/msgs.go 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b43c5...ecd3fe2. Read the comment docs.

Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM removed this from the v0.10.0 milestone Jul 17, 2020
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍

Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM merged commit 9657837 into master Jul 17, 2020
@RiccardoM RiccardoM deleted the riccardo/error-improvements branch July 17, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the error formatting The error message is not user friendly
2 participants