-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refuse and Cancel features for DTag #305
Merged
Merged
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e49e832
removed relationship event attribute key prefix
leobragaz 17bbbd6
Merge remote-tracking branch 'origin/master'
leobragaz c118df8
Merge remote-tracking branch 'origin/master'
leobragaz ba07fd4
Merge remote-tracking branch 'origin/master'
leobragaz 702abbf
added new msgs reject and cancel + tests
leobragaz b580514
added handler and keeper functions + tests
leobragaz f32eb82
added integration and simulation tests
leobragaz 2e58ff4
Merge branch 'master' of https://github.com/desmos-labs/desmos into l…
leobragaz 557f6e2
trying to fix cli tests error
leobragaz e9ab468
trying to fix cli tests error 2
leobragaz 38a82fd
fixed error in cli command description
leobragaz bc6c9e9
fixed errors in cli tests
leobragaz 6154a1a
fixed errors in cli tests
leobragaz c2db582
added missing cli test line
leobragaz 6d06ba9
trying to fix cli tests error
leobragaz 44aa717
trying to fix cli tests error
leobragaz fec8413
trying to remove two tests
leobragaz 06ec6b7
readd the tests
leobragaz 55fb68b
aligned all dTag transfer related names
leobragaz ad61493
fixed suggestions
leobragaz b75f09b
fixed rest endpoints
leobragaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
docs/developers/msgs/profiles/cancel-dtag-transfer-request.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# `MsgCancelDTagTransferRequest` | ||
This message allows you to cancel a `DTag`'s transfer request made by yourself. | ||
|
||
## Structure | ||
````json | ||
{ | ||
"type": "desmos/MsgCancelDTagTransferRequest", | ||
"value": { | ||
"sender": "<Desmos address that sent the DTag's request>", | ||
"owner": "<Desmos address of the DTag owner>" | ||
} | ||
} | ||
```` | ||
|
||
### Attributes | ||
| Attribute | Type | Description | | ||
| :-------: | :----: | :-------- | | ||
| `sender`| String | Desmos address of the user that request the `DTag` | | ||
| `owner` | String | Desmos address of the user that is the owner of the requested `DTag` | | ||
RiccardoM marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Example | ||
````json | ||
{ | ||
"type": "desmos/MsgCancelDTagTransferRequest", | ||
"value": { | ||
"sender": "desmos1nhgk008jvrxwa9tufr9tcr6zfrhe2uz0v90r2a", | ||
"owner": "desmos1k99c8htyk32srx78efzg7sxm965prtz0j9qrc7" | ||
RiccardoM marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
```` | ||
|
||
## Message action | ||
The action associated to this message is the following: | ||
|
||
``` | ||
cancel_dtag_request | ||
``` |
37 changes: 37 additions & 0 deletions
37
docs/developers/msgs/profiles/refuse-dtag-transfer-request.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# `MsgRefuseDTagTransferRequest` | ||
This message allows you to refuse a `DTag`'s transfer request made by a user. | ||
RiccardoM marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Structure | ||
````json | ||
{ | ||
"type": "desmos/MsgRefuseDTagTransferRequest", | ||
"value": { | ||
"sender": "<Desmos address that sent the DTag's request>", | ||
"owner": "<Desmos address of the DTag owner>" | ||
} | ||
} | ||
```` | ||
|
||
### Attributes | ||
| Attribute | Type | Description | | ||
| :-------: | :----: | :-------- | | ||
| `sender`| String | Desmos address of the user that request the `DTag` | | ||
| `owner` | String | Desmos address of the user that is the owner of the requested `DTag` | | ||
|
||
## Example | ||
````json | ||
{ | ||
"type": "desmos/MsgRefuseDTagTransferRequest", | ||
"value": { | ||
"sender": "desmos1nhgk008jvrxwa9tufr9tcr6zfrhe2uz0v90r2a", | ||
"owner": "desmos1k99c8htyk32srx78efzg7sxm965prtz0j9qrc7" | ||
} | ||
} | ||
```` | ||
|
||
## Message action | ||
The action associated to this message is the following: | ||
|
||
``` | ||
refuse_dtag_request | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we revert all the changes that were made to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes I made were to fix some errors inside tests to exclude them from the possible causes that make the whole suite fail, should I revert them anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bragaz Yes please, they were part of tests that have always been passing so I don't think they consitute any problem