Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration and genesis validation fixes #340

Merged
merged 22 commits into from
Jan 14, 2021

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jan 14, 2021

Description

  • Removed the block-interval flag from the migrate command
  • Changed the migrate command to use v0.15.0 instead of stargate, for consistency
  • Changed v0.15.0 migration types to use the current types
  • Changed all PostID to PostId and ParentID to ParentId
  • Fixed genesis validation errors

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM RiccardoM enabled auto-merge (squash) January 14, 2021 10:56
@RiccardoM RiccardoM removed the request for review from leobragaz January 14, 2021 11:09
- Changed v0.15.0 migration types to use the current types
- Changed all PostID to PostId and ParentID to ParentId

Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #340 (018b98e) into master (8eafbff) will increase coverage by 0.00%.
The diff coverage is 84.69%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   82.02%   82.03%           
=======================================
  Files          99       99           
  Lines        3756     3758    +2     
=======================================
+ Hits         3081     3083    +2     
  Misses        564      564           
  Partials      111      111           
Impacted Files Coverage Δ
x/posts/client/cli/query.go 61.02% <0.00%> (ø)
x/posts/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/posts/legacy/v0.15.0/types.go 0.00% <0.00%> (ø)
x/profiles/legacy/v0.15.0/types.go 100.00% <ø> (ø)
x/relationships/legacy/v0.15.0/types.go 0.00% <ø> (ø)
x/reports/legacy/v0.15.0/types.go 0.00% <0.00%> (ø)
x/posts/types/posts.go 89.61% <57.14%> (ø)
x/posts/types/msgs.go 96.35% <86.66%> (ø)
x/posts/keeper/msgs_server.go 95.23% <96.66%> (ø)
x/genutil/legacy/v0.15.0/migrate.go 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bd4ca...018b98e. Read the comment docs.

- Fixed genesis validation errors
- Fixed lint errors

Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM changed the title Migration fixes Migration and genesis validation fixes Jan 14, 2021
Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM merged commit 1fcdb0b into master Jan 14, 2021
@RiccardoM RiccardoM deleted the riccardo/removed-block-interval-flag branch January 14, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants