Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed binary to be desmos #343

Merged
merged 5 commits into from
Jan 15, 2021
Merged

Renamed binary to be desmos #343

merged 5 commits into from
Jan 15, 2021

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jan 15, 2021

Description

Renamed binary from desmosd to desmos. Closes #342.

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #343 (cf84812) into master (1fcdb0b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   82.03%   82.03%           
=======================================
  Files          99       99           
  Lines        3758     3758           
=======================================
  Hits         3083     3083           
  Misses        564      564           
  Partials      111      111           
Impacted Files Coverage Δ
app/app.go 84.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea597f...cf84812. Read the comment docs.

@RiccardoM RiccardoM enabled auto-merge (squash) January 15, 2021 09:55
Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM merged commit 5b1ceca into master Jan 15, 2021
@RiccardoM RiccardoM deleted the riccardo/change-binary-name branch January 15, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we name the new binary desmos instead of desmosd?
2 participants