Post and Like structure revist #40
Conversation
- Removed the Namespace and ExternalOwner fields - Changed how the likes for a given post are stored
Fixed some tests and formatted them using the gotests style
RiccardoM
added
kind/enhancement
|
Let's target merging it this weekend and launch testnet. |
Signed-off-by: RiccardoM <riccardo.montagnin@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #40 +/- ##
============================================
+ Coverage 61.18% 81.47% +20.29%
============================================
Files 13 13
Lines 541 502 -39
============================================
+ Hits 331 409 +78
+ Misses 192 84 -108
+ Partials 18 9 -9
Continue to review full report at Codecov.
|
| if err := keeper.CreateSession(ctx, session); err != nil { | ||
| // Check for any previously existing session | ||
| if _, found := keeper.GetSession(ctx, session.SessionID); found { | ||
| return sdk.ErrUnknownRequest(fmt.Sprintf("Session with id %s already exists", session.SessionID)).Result() |
There was a problem hiding this comment.
Not a big deal but looks strange if a function is named GetSession where the function is to check whether the session exists.
There was a problem hiding this comment.
The GetSession here is used to check if a session already exists, but elsewhere (i.e inside the querier) the same method is used to get a session using its ID.
Here we use the second returned value, which allows for faster and easier comparison than the first one. It's just a convinient way to keep the code DRY and avoiding having multiple methods with very similar functionality
| if err := k.SaveLike(ctx, like); err != nil { | ||
| return err | ||
| // Check for double likes | ||
| if likes.ContainsOwnerLike(like.Owner) { |
There was a problem hiding this comment.
Possible to query the state before broadcasting the message?
There was a problem hiding this comment.
Unluckily, not. The ValidateBasic method has no access to the state.
On the other hand, we can move this to the handler. Do you think it would be better?
Signed-off-by: RiccardoM <riccardo.montagnin@gmail.com>
Description
This PR implements various
PostandLikestructure improvements.Also, the various messages have been revisited in order to delete useless time fields.
Tests have been added and documentation has been written.
Closes #39
Checklist
Files changedin the Github PR explorer