Profiles fixes

[leobragaz]

Description

This PR fixes some bugs of the x/profiles module.
Closes #413.
Closes #414.

Checklist

• Targeted PR against correct branch.
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Wrote unit tests.
• Wrote integration tests (simulation & CLI).
• Updated the documentation.
• Added an entry to the CHANGELOG.md file.
• Re-reviewed Files changed in the Github PR explorer.

[codecov]

Codecov Report

Merging #415 (ca22411) into master (8eae4ab) will not change coverage.
The diff coverage is 85.41%.

❗ Current head ca22411 differs from pull request most recent head 2df4bb3. Consider uploading reports for the commit 2df4bb3 to get more accurate results

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          66       66           
  Lines        3429     3429           
=======================================
  Hits         2484     2484           
  Misses        847      847           
  Partials       98       98           

Impacted Files	Coverage Δ
x/profiles/types/account.go	55.26% <55.55%> (ø)
x/profiles/types/params.go	81.66% <87.50%> (ø)
x/profiles/client/cli/tx.go	78.45% <100.00%> (ø)
x/profiles/keeper/keeper.go	96.49% <100.00%> (ø)
x/profiles/keeper/msgs_server.go	83.57% <100.00%> (ø)
x/profiles/types/msgs.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eae4ab...2df4bb3. Read the comment docs.

[RiccardoM]

Everything looks great. Could you please add a function that converts an old Profile into a new one? We will need this because this changes will need to be applied into the currently running testnet, and we need such function to be run during the upgrade.

The best approach would be to follow Cosmos one as done here (just we don't need the queryServer, we only need to perform the migration):

https://github.com/cosmos/cosmos-sdk/blob/master/x/auth/keeper/migrations.go

[leobragaz]

@RiccardoM I've added a legacy test that should fit the purpose, it looks like you've said that Protobuf doesn't care about fields names.