Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile serialization fix #417

Merged
merged 4 commits into from
May 6, 2021
Merged

Profile serialization fix #417

merged 4 commits into from
May 6, 2021

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented May 6, 2021

Description

This PR updated how a profile is updated, fixes #416

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: riccardo.montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM requested a review from leobragaz May 6, 2021 06:06
@RiccardoM RiccardoM modified the milestone: v0.16.2 May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #417 (8193ac7) into master (d7319ab) will increase coverage by 1.93%.
The diff coverage is 89.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   70.50%   72.44%   +1.93%     
==========================================
  Files          90       66      -24     
  Lines        3696     3429     -267     
==========================================
- Hits         2606     2484     -122     
+ Misses       1005      847     -158     
- Partials       85       98      +13     
Impacted Files Coverage Δ
x/staging/posts/keeper/keeper.go 100.00% <ø> (ø)
x/staging/reports/keeper/keeper.go 100.00% <ø> (ø)
x/profiles/keeper/grpc_query.go 67.56% <14.28%> (-13.08%) ⬇️
x/profiles/types/account.go 55.26% <64.70%> (+10.10%) ⬆️
x/profiles/keeper/alias_functions.go 84.61% <66.66%> (-15.39%) ⬇️
x/profiles/client/cli/query.go 64.21% <69.44%> (+4.21%) ⬆️
x/profiles/keeper/querier.go 70.31% <72.22%> (+1.56%) ⬆️
x/profiles/client/cli/tx.go 78.45% <79.66%> (+0.58%) ⬆️
x/profiles/types/genesis.go 92.30% <88.23%> (-7.70%) ⬇️
x/profiles/types/params.go 81.66% <90.90%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8ffcf...8193ac7. Read the comment docs.

@RiccardoM RiccardoM merged commit 8eae4ab into master May 6, 2021
@RiccardoM RiccardoM deleted the riccardo/profile-bug-fix branch May 6, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing a transaction with a profile results in never-ending balance withdraws
2 participants