Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify profile with external applications #502

Merged
merged 19 commits into from
Jun 22, 2021
Merged

Verify profile with external applications #502

merged 19 commits into from
Jun 22, 2021

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jun 21, 2021 •
edited
Loading

Description

This PR implements the feature that allows users to connect their Desmos profile with centralized applications. It represents the result of the work done inside the following PRs:

It closes #472

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM
Added app links Proto files
c2c229d 
See PR #473
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
ccdc209 
…app-links
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
0ae6ff7 
…app-links
@RiccardoM
Implemented application links logic
e94b29b 
See PR #479
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
99afefa 
…app-links

� Conflicts:
�	proto/desmos/profiles/v1beta1/genesis.proto
�	x/profiles/client/cli/cli_chain_links.go
�	x/profiles/client/cli/query.go
�	x/profiles/keeper/alias_functions.go
�	x/profiles/keeper/genesis.go
�	x/profiles/keeper/genesis_test.go
�	x/profiles/keeper/keeper.go
�	x/profiles/types/genesis.go
�	x/profiles/types/genesis.pb.go
�	x/profiles/types/genesis_test.go
�	x/profiles/types/keys.go
�	x/profiles/types/query.pb.go
�	x/profiles/types/query.pb.gw.go
@RiccardoM
Merged master
2e38a67 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM
Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…
f86a674 
…app-links

� Conflicts:
�	go.mod
�	proto/desmos/profiles/v1beta1/genesis.proto
�	proto/desmos/profiles/v1beta1/models_app_links.proto
�	x/profiles/client/cli/cli_app_links.go
�	x/profiles/client/cli/query.go
�	x/profiles/keeper/alias_functions.go
�	x/profiles/keeper/genesis.go
�	x/profiles/keeper/genesis_test.go
�	x/profiles/keeper/keeper_app_links.go
�	x/profiles/keeper/keeper_ibc.go
�	x/profiles/keeper/relay_app_links.go
�	x/profiles/keeper/relay_app_links_test.go
�	x/profiles/module_ibc.go
�	x/profiles/types/genesis.go
�	x/profiles/types/genesis.pb.go
�	x/profiles/types/genesis_test.go
�	x/profiles/types/keys.go
�	x/profiles/types/models_app_links.go
�	x/profiles/types/models_app_links.pb.go
�	x/profiles/types/msgs_app_links.go
@RiccardoM
Fixed tests
64e1707 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM changed the title Riccardo/app links Verifiy profile with external applications Jun 21, 2021
@RiccardoM RiccardoM changed the title Verifiy profile with external applications Verify profile with external applications Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #502 (7914938) into master (77981c8) will increase coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   83.94%   83.98%   +0.03%     
==========================================
  Files          90       90              
  Lines        4404     4407       +3     
==========================================
+ Hits         3697     3701       +4     
+ Misses        547      546       -1     
  Partials      160      160
Impacted Files Coverage Δ
x/profiles/client/cli/cli_app_links.go 31.11% <0.00%> (+0.34%) ⬆️
x/profiles/keeper/relay_app_links.go 95.31% <100.00%> (+0.19%) ⬆️
x/profiles/types/msgs_app_links.go 86.00% <100.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77981c8...7914938. Read the comment docs.

@RiccardoM RiccardoM marked this pull request as ready for review June 21, 2021 09:13
@RiccardoM
Added CHANGELOG entry
e2c08a2 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM
Added the documentation and changed how the MsgLinkApplication is formed
bf6f2d3 
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM requested review from dadamu and leobragaz and removed request for dadamu June 22, 2021 05:43
@RiccardoM @leobragaz
Update docs/developers/msgs/profiles/link-application.md
7e32d33 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@RiccardoM @leobragaz
Update docs/developers/msgs/profiles/unlink-application.md
729ad4b 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@RiccardoM @leobragaz
Update docs/developers/msgs/profiles/unlink-application.md
702bb5a 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@RiccardoM @leobragaz
Update docs/developers/msgs/profiles/unlink-application.md
2b2b1aa 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
RiccardoM and others added 4 commits June 22, 2021 08:59
@RiccardoM @leobragaz
Update docs/developers/types/profiles/application-link.md
69a49ac 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@RiccardoM @leobragaz
Update docs/developers/types/profiles/application-link.md
eb81e61 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@RiccardoM @leobragaz
Update docs/developers/types/profiles/application-link.md
f2c606a 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@RiccardoM @leobragaz
Update docs/developers/types/profiles/application-link.md
5fbfb97 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
leobragaz
leobragaz reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small grammar stuff in docs

@RiccardoM RiccardoM merged commit 35217c9 into master Jun 22, 2021
@RiccardoM RiccardoM deleted the riccardo/app-links branch June 22, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobragaz leobragaz leobragaz approved these changes

@dadamu dadamu Awaiting requested review from dadamu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify profile with centralized applications
2 participants
@RiccardoM @leobragaz