Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed: duplicate snapshot documentation #549

Merged
merged 2 commits into from
Jul 9, 2021
Merged

removed: duplicate snapshot documentation #549

merged 2 commits into from
Jul 9, 2021

Conversation

ryuash
Copy link
Contributor

@ryuash ryuash commented Jul 9, 2021 •
edited
Loading

Description

Recently we updated the docs and ended up duplicating sections regarding snapshots. I removed it and fixed the section numbering

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@ryuash ryuash marked this pull request as ready for review July 9, 2021 05:52
@ryuash ryuash requested a review from kwunyeung July 9, 2021 05:52
kwunyeung
kwunyeung approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@kwunyeung kwunyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kwunyeung kwunyeung merged commit 033dc74 into master Jul 9, 2021
@kwunyeung kwunyeung deleted the hotfix/docs branch July 9, 2021 06:55
@RiccardoM RiccardoM mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwunyeung kwunyeung kwunyeung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryuash @kwunyeung